X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 62FD4DC0846
	for <alpine-devel@lists.alpinelinux.org>; Fri, 17 Oct 2014 13:05:56 +0000 (UTC)
Received: by mail-la0-f52.google.com with SMTP id hz20so642842lab.25
        for <alpine-devel@lists.alpinelinux.org>; Fri, 17 Oct 2014 06:05:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=BZt7fYXPKG3w37puCEVRtoJpsn1KVgrRO7FxPLHpeWI=;
        b=sqFjhMoNz/DWS2ota+3FD0n59zdYoQQf9KVCQwSuJXhyLhYBu1UJG1sQU3cD79uN5H
         Kzxb820WbEj8+4f1l+olKSNm8Jaoo/dNkxhwJgcma7WWiHpx2Qr+M3lz1XRK5rPSdtzr
         ZE34wGdt5uXTrA/D/J7fLliIsuTz9US9G2L4NMG7/drzUoxBsid4Eu5EO+IcDK1GK/zk
         Z7I6/woCdo/ZAyOPD+//BNwm2kidIbj4cdkwA1C+pqSyXwWys29f51Yqq8IgLXzPmZ0T
         sZiA66Q9519xdztkk3SJgGpbNV5t1ytdhVUMeXYlhY7u0rHhKM/jddBwHo5yG3uQo37I
         ZIMA==
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
X-Received: by 10.152.7.233 with SMTP id m9mr8856931laa.32.1413551153654; Fri,
 17 Oct 2014 06:05:53 -0700 (PDT)
Received: by 10.25.84.65 with HTTP; Fri, 17 Oct 2014 06:05:53 -0700 (PDT)
Date: Fri, 17 Oct 2014 17:05:53 +0400
Message-ID: <CAOoJqMdXw-uL_6B1S=CQQv97=FBJRdMyyhoHpspi91=ZZui84g@mail.gmail.com>
Subject: [alpine-devel] [PATCH] multipath-tools: fixing the way to call functions
From: Sergey T <gsergeyt@gmail.com>
To: alpine-devel@lists.alpinelinux.org
Content-Type: multipart/alternative; boundary=001a11c34e3e62b1ef05059e065f

--001a11c34e3e62b1ef05059e065f
Content-Type: text/plain; charset=UTF-8

Dear friends,

It would be better to remove "()" in undo_nodes() and do_nodes() strings
because /sbin/runscript actually does not call functions this way.

Regards.
-Sheavy

--- aports/main/multipath-tools/multipath-tools.initd.orig
+++ aports/main/multipath-tools/multipath-tools.initd
@@ -25,13 +25,13 @@
  ebegin "Starting multipathd"
  start-stop-daemon --start --quiet --make-pidfile \
   --pidfile /var/run/multipathd.pid --exec /sbin/multipathd
- do_nodes()
+ do_nodes
  eend $?
 }

 stop() {
  ebegin "Stopping multipathd"
- undo_nodes()
+ undo_nodes
  start-stop-daemon --stop --quiet --retry --pidfile /var/run/multipathd.pid
  eend $?
 }

--001a11c34e3e62b1ef05059e065f
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr"><div>Dear frie=
nds, </div><div><br></div><div>It would be better to remove &quot;()&quot; =
in undo_nodes() and do_nodes() strings because /sbin/runscript actually=C2=
=A0does not=C2=A0call functions this way.</div><div><br></div><div>Regards.=
</div><div>-Sheavy</div><div><br></div><div>--- aports/main/multipath-tools=
/multipath-tools.initd.orig<br>+++ aports/main/multipath-tools/multipath-to=
ols.initd<br>@@ -25,13 +25,13 @@<br>=C2=A0=C2=A0ebegin &quot;Starting multi=
pathd&quot;<br>=C2=A0=C2=A0start-stop-daemon --start --quiet --make-pidfile=
 \<br>=C2=A0=C2=A0 --pidfile /var/run/multipathd.pid --exec /sbin/multipath=
d<br>-=C2=A0do_nodes()<br>+=C2=A0do_nodes<br>=C2=A0=C2=A0eend $?<br>=C2=A0}=
<br>=C2=A0<br>=C2=A0stop() {<br>=C2=A0=C2=A0ebegin &quot;Stopping multipath=
d&quot;<br>-=C2=A0undo_nodes()<br>+=C2=A0undo_nodes<br>=C2=A0=C2=A0start-st=
op-daemon --stop --quiet --retry --pidfile /var/run/multipathd.pid<br>=C2=
=A0=C2=A0eend $?<br>=C2=A0}</div></div></div>
</div>

--001a11c34e3e62b1ef05059e065f--


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---