Date: Thu, 30 Jun 2022 16:39:49 +0900
From: Dominique Martinet <asmadeus@codewreck.org>
To: "Daniel F. Dickinson" <dfdpublic@wildtechgarden.ca>
Cc: ~alpine/devel@lists.alpinelinux.org
Subject: Re: Fixing shell script libraries like /lib/libalpine.sh
Message-ID: <Yr1TRebPEJ/SfWoG@codewreck.org>
References: <4caa8c5f-7ebf-ad2f-0e92-29428785fe60@wildtechgarden.ca>
 <Yr1Lll3DNQGGeAGt@codewreck.org>
 <2512fab8-7ae4-c554-32a9-333a2b08813c@wildtechgarden.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2512fab8-7ae4-c554-32a9-333a2b08813c@wildtechgarden.ca>

Daniel F. Dickinson wrote on Thu, Jun 30, 2022 at 03:31:50AM -0400:
> This calls setup-ntp with NTPOPTS as the parameter; perhaps the issue is
> the quoting there. In any event, I've obviously got to do some more
> complete troubleshooting, fix, and test thereof.

The problem is setup-ntp sets 'resp' from parsing -c in getopts loop,
but actually expects it to be the first positional parameter e.g.
'setup-ntp chrony' as it checks $# and assigns resp from $1 regardless
of $#.

It shouldn't be too hard to make it work with either -c or first
positional parameter, letting you send a MR on gitlab :)


(oh, and I use reply to all and think most others do as well -- but I
don't know if it really is a rule or just habits from other lists where
non-subscribers can post)
--
Dominique