X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mail.bitmessage.ch (mail.bitmessage.ch [146.228.112.252]) by lists.alpinelinux.org (Postfix) with ESMTP id B68325C5542 for ; Mon, 30 Jul 2018 23:31:03 +0000 (GMT) dkim-signature: v=1; a=rsa-sha256; d=bitmessage.ch; s=mail; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References; bh=acaTzsTcHvtcyrgku9IUhq40JTHks8bYWxREqXWA1yE=; b=Ed8GdnG4YZ5CSUTlpWszjs5bqhfWMK/c+p+LjKUSCCuTte5x5+4U0EGJcalIWpS1aBe6FAw5wufERv21Ms2MHft71nBd22qGXf7EIoK3+qizDBceUGbXLqIY+dQCSkXPk69WueLZYPqm6bsq/s5IF+l5iXE/gUdz+WgV7j7w808= Received: from [127.0.0.1] (BITMESSAGE [127.0.0.1]) by mail.bitmessage.ch with ESMTPA ; Tue, 31 Jul 2018 01:30:29 +0200 To: alpine-devel@lists.alpinelinux.org References: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> From: Oliver Smith Openpgp: preference=signencrypt Autocrypt: addr=ollieparanoid@bitmessage.ch; prefer-encrypt=mutual; keydata= xsFNBFkgqFYBEACpmb35WGjNXMOALKSpRaZSLnPSQWMGFS1bVbMl4ugIP4aqQCN4qUeC3DAh 57OajhP9eWwbyeAh9l7G2sJYaiuJOonQsnLdNe4vXLH9r8rpr7EAgv6RsiuShIox7W45z1p6 v3SJQi5W+tayzXAsr1shYHKIhx48xBdDjqxHIvYaoyMTiWqyp4o4W0YlH4MTafuEjW1wANma e9thyyhbdRql2kcLjIAkLNRh7rGI3NT0bJboc5p71srv2TqwbbrMOZtmRo9qPFPUpAt7qFaf aRVaasXiIR+zLHfIoW1g7tlzdLPrW1QVvPNBOIUMA4NqKSWiQxsgzdu7Suydou3Kb4O0FHRv vHdfOkB07uECSZTZSdseIXOu9Ofsi6tD0hhz+7ODqknM9IFlPD32CY/H3uvbw9u5qyDAlaSV 6b1djAVzCgc5zJM/WQx8GbH9ww5i8iG+2b/OSSGQRUOr0wxpXDKuN1gbXwZhtVVa56icKJta bbTyhIZZi2/XNqxPtcZxV9LTZ0+uNXcHelO8g/qFNJX0aCtAfaLwec5OZ1qppjeQ8paos13N JtBnH7U+0OCcH7B4Hc91I6L5qnUHQBC84MqLehw/XSBYEp56NXrRJByn9cVCoqWoD+Og4YCx pn0QboraBbYBg32jP8nEt3IRYWyD7hrU3szH9H+OlpCUHFhzYQARAQABzSpPbGl2ZXIgU21p dGggPG9sbGllcGFyYW5vaWRAYml0bWVzc2FnZS5jaD7CwY4EEwEIADgCGyMFCwkIBwIGFQgJ CgsCBBYCAwECHgECF4AWIQRW6FMNtYvcgBJX9fBa5/VRPgiFywUCWSCsbwAKCRBa5/VRPgiF y5YOEACTnQ9cb6tWuabTUduoi5UV6A1M/CU1ZnCvTVPCu72pfjn1idniAtis0Q25UfAs3FNr 8user54eBfLB9X/6LPU97VeKrOz2j0IVDAneL99YyK2xLw02a0vVDpnhCvP1fZZEtnmt1Z/v DCvU2BKTNV62w3S6ZojKQqS25/gPny06seJW38P7Md7lJNwvwsjiL/j29REWRI1SYUI1N3OG +tSVWhNNGXNaYSLpGh481JAbp7o+xb+e9Gl+PSIyu2uThAjYcKLm32yorrK8VGMUzqf/FN1z 9VLQWWMMTA/NFwj+HQaaFoEnUu9H2Epw/Vcz4sGanhv/Fjc3QeRfiUbCAdqFtCE1iDfmYvX+ gODyJi2xpQ2MLTS6DOL5J3JXOIBRHPkjsDl6vuxxxjzLhWUbn4PpU/fNYap2dp1A19IH2IxR Ka7ClzYI8wrxW7APjbP/Ii9Md6KXTJWLQ+RGsQ8LvOTPVMXzdmqCLe3SwgSrGH9xr4pNm8qf PAclsuWlqyEEdWFj5080m98ZJgU0A1yHH95bmrWmhugaAydEC/uTc2tSMYrqRWzL12bAGBig 493Vx3I9it6fECVSPdWEw7KwqK2J10X4lvryODAzg4biPnOVFQeR9Nup/HBPWv7u3oFefl+7 1QENkMD1AIVhtrT0NMRO8qlsd8KhbVVCQTxfsWEVnc7BTQRZIKhWARAAtnQOhY4KQwU4io++ WxmiNIKuvA5lzMDugBCK/EcY8hNjVh3L2JjgJ1izwcL2mWaUL384tyBODoAAwlShDObfc8LN ozIHVr0JOoblFPR6Jzi9WVq0dquqvqd8ZQu2AXiSjvyvqlqlmX3+/+duSqGa6/p/fYorpCmt TIkGI9CEB8ZabEtlj/rA09QhMnlkHEM9pPtzuUDhddxx7qJ6qFwtp2+WGT7Cd4fHKrnk5Yfw G4RxubxsFkC/3ekO/hmnqkDhM7xTOR7e5+3EHaRoYDAW6DD+QfhLnPFtSLl71G7mzQ9unvM/ H6lWtZLb4SSqOxsNUJwY9FUkqLWnHxeC1xkVNjeRCf0ojobPxmRwG4/uQlE5UNwUolgPzYUU +EbZjtB1TZpD9wVILjkJrkVfdjdGjT3WTuMYbZbF3i63cq2T4jnktfW0zU6LZAsB+sn/Fbka SBQqN39o+1EhjPEJS5sYksPgHxpLyWgPcUaLilFnoTXAJMafj2B8Pq7yNs/izLGbrNIXvByM ZblbkO1SsKmDxYyV4mPDpc6nMVbIMGE5T0HVElBy8nc0kXMrRo2iidm9r2uMdIzTDK4ik8oY aZ1gzPCeL/+rGKA94n6heow5CKJeEb7L22DoPKYVv9JOjLhbZ2+jxZKoCe2NfyRac7PbiDgz tzmks+vzZFmyBSRANrsAEQEAAcLBdgQYAQgAIAIbDBYhBFboUw21i9yAElf18Frn9VE+CIXL BQJZIKx1AAoJEFrn9VE+CIXL84UP/3l/f77Sfn2Ldwh2h+GyK4Em20/BNgnYx5H8lvKFCswd 2yWp4gO92rrmgnfa43Hl3x7/4Afn2WV5/kQwJL41xoJhhi3n3nOxPzXrHRi2eonLzwup09VC hs4Sg4Q7fHeUK+fXyKg7KgUY5LHDoYH6Md8Cuy5Er6st9Xam6daXDmkVVVQ74b2yXMfsW9h8 yBpWjg+JSh68LZf0quevM4iLEq+qZVvRM8lzaDyVs6fAT4iNmaw/+5+RZi7aCH2PLRRIwR4f Ufha/MNo1nupLSnQD16kfB5DHkwbHWp96USVkYHl/lxGN55FjH1dP5TBfgAsurCjmxWxZTQp S+sqivEElg4j7+rpIOLCugskq8EN0Hv7j9nOaov7iB/BzubT9XHqy518/IQ0UAaNPgowpvx7 ISd9QXpMhTSeETVgLTv4SaoZZqE2UUKVVkbF5RAt2ykF/4Iow2UEX9nyg0g3g5LW82zV6xyG m+XdIAoRawBe1vcS0xHfysfqEK23YTpQC4Q69yfjHknaA6rK8rvPrQJK34JWMICes6A91RpA 51CsEVUZTIha6nkIRF2aOdZaC2NeVhbYX66YEERV2EA5Wy7Fi5ES/7/mhQRkqCj6r6Zw2Py3 fUwz07s/NcFvqkrICZDTmCH4jydV6jUgLwzw4uf82HKwmQxPvyw1XWaK9fXUMON2 Subject: Re: [alpine-devel] How to improve quality control for patch reviews Message-ID: Date: Mon, 30 Jul 2018 23:30:00 +0000 X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 In-Reply-To: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hey everyone, I had looked into CI quality improvement tools for aports at some point, and found these: * shellcheck: catches lots of shell errors, can be set to POSIX shell * shfmt: could be used to enforce a certain syntax in the shell (similar to PEP8 for Python) (we're using shellcheck in pmbootstrap/aports for post-install scripts so far, not for APKBUILDs yet, but that should also work) The catch is, that both are not packaged for Alpine yet. Another point where automation could help is soname breakage: sometimes one package get updated, but other packages depending on it do not get a pkgrel bump. The APKINDEX file already contains information which programs depend on which sonames, so it is possible to figure out what will break. We have such a CI job for postmarketOS packages in pmbootstrap (written in Python), and if there's interest, I could port it so it works independently in Alpine's aports repository. (I'm pretty busy right now, so it will take me a while though.) Thanks, Oliver Natanael Copa: > Hi! > > We have had a few complaints from Jakub Jirutka about qualtiy control. > > A recent example is > https://github.com/alpinelinux/aports/commit/6c21984c5b86ca03c72a88927f8c1de0c420e25f#commitcomment-29834072 > > We do struggle with keep up with the PR queue and at the same time do > good enough quality control. I also think we may have different > opinions what is good enough. > > I wonder if you have any ideas how we deal with this? > > A few things I think we can do: > > - improve documentation. Write documentation with a simple checklist > you can look over before you submit a PR. For example, "check that > license is in SPDX format[1]", "check that it does not automatically > start services from pre-install", etc. This will make it easier for > people doing patch reviews and can be useful when adding automated > checks. > > - add more automatic checks > > - give more people push access. Look for people that are candidates to > get push access. Help them to improve. Follow up when they are "good > enough". > > > Any other ideas or thoughts? > > -nc > > 1: https://spdx.org/licenses/ > > > --- > Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org > Help: alpine-devel+help@lists.alpinelinux.org > --- > > --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---