From: Dubiousjim <dubiousjim@gmail.com>
To: alpine-devel@lists.alpinelinux.org
Subject: [alpine-devel] [PATCH] patch and 2 questions for alpine-conf repo
Date: Fri,  5 Jul 2013 00:46:10 -0400
Message-Id: <cover.1372998997.git.dubiousjim@gmail.com>
Precedence: list

Thanks for applying the alpine-conf patches I sent the other day, but this is still
needed to clean up the VERSION reference. (Sorry for sending the bad patch in the first place here.)

Also:

Q1. Like abuild, I notice this Makefile also has a "dist" target. Might we still use that? If not should we purge it?

Q2. There's also a funny extension target, for the extension ".sh.in.sh". Is that correct, or a typo?

The abuild repo's Makefile has:

	.SUFFIXES:      .sh.in .in
	%.sh: %.sh.in
	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
	        ${CHMOD} +x $@
	
	%: %.in
	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
	        ${CHMOD} +x $@

which makes natural sense. Whereas alpine-conf's Makefile has:

	.SUFFIXES:      .sh.in .in
	.sh.in.sh:
	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
	
	.in:
	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@

On the face of it, those rules look screwy, but maybe there's some (overly?) clever
Makefile-fu going on here that I haven't divined.


Dubiousjim (1):
  update-conf: fix version

 update-conf.in | 2 ++
 1 file changed, 2 insertions(+)

-- 
1.8.3.1



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---