Date: Fri, 21 Feb 2020 16:48:27 +0000
To: Kevin Daudt <kdaudt@alpinelinux.org>
From: Rasmus Thomsen <oss@cogitri.dev>
Cc: ~alpine/devel@lists.alpinelinux.org
Reply-To: Rasmus Thomsen <oss@cogitri.dev>
Subject: Re: Using buildtypes that respect our C{,PP,XX}FLAGS in CMake and Meson
Message-ID: <d6822514d183531fecd09b40bd02141421c4cf70.camel@cogitri.dev>
In-Reply-To: <20200220174426.GA1247035@alpha>
References: <2896c13070c508a49cbaa72c8fb7f34ea947358b.camel@cogitri.dev>
 <20200220174426.GA1247035@alpha>
Feedback-ID: LZW2MXNaH7NSG88i8lGpebeqB0wmcl0-3TbzkSuzsmAwEQspn4GI-WRe8j3PhRL4SBmua4rQWq6fadPcLS5uxQ==:Ext:ProtonMail
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 2020-02-20 at 18:44 +0100, Kevin Daudt wrote:
> On Thu, Feb 20, 2020 at 05:20:45PM +0000, Rasmus Thomsen wrote:
> > Hello list,
> >=20
> > [..]
> >=20
> > As such I'd suggest multiple steps to be taken:
> >=20
> > 1) Change existing aports over to the None/plain buildtype to make
> > sure
> > this doesn't break anything (we'll probably use some performance
> > but
> > get smaller packages due to our CFLAGS, but that's the goal here, I
> > suppose)
> >=20
> > 2) Change Alpine policy to only use the None/plain buildtype.
> > Additionally, the buildtype _must be_ mentioned, since at least
> > Meson
> > defaults to 'debug' if no buildtype is specified.
> >=20
> > 3) Change newapkbuild so that new aports use the correct buildtype
> > (
> > https://gitlab.alpinelinux.org/alpine/abuild/merge_requests/29)
> >=20
> > Thanks,
> >=20
> > Rasmus Thomsen
> >=20
>=20
> If feasible, we could add a linting check to verify that the proper
> buildtype is used as well.

That sounds like a good idea, I guess we could check if cmake is
mentioned in an APKBUILD and if so, if the right CMAKE_BUILD_TYPE is
used (and the same for meson with buildtype).