To: Natanael Copa <ncopa@alpinelinux.org>
References: <c471c82c-f128-58ba-f903-1e25ad5c857d@bitmessage.ch>
 <20190109095332.410fd5f1@ncopa-desktop.copa.dup.pw>
 <f41c6ca2-3145-0eac-897d-ba284d1c992a@bitmessage.ch>
 <90ef5de9-9b84-7bec-dcce-4de4ef02a670@bitmessage.ch>
 <20190314103123.18921d4f@ncopa-desktop.copa.dup.pw>
Cc: alpine-devel@lists.alpinelinux.org
From: Oliver Smith <ollieparanoid@bitmessage.ch>
Openpgp: preference=signencrypt
Autocrypt: addr=ollieparanoid@bitmessage.ch; prefer-encrypt=mutual; keydata=
 mQINBFkgqFYBEACpmb35WGjNXMOALKSpRaZSLnPSQWMGFS1bVbMl4ugIP4aqQCN4qUeC3DAh
 57OajhP9eWwbyeAh9l7G2sJYaiuJOonQsnLdNe4vXLH9r8rpr7EAgv6RsiuShIox7W45z1p6
 v3SJQi5W+tayzXAsr1shYHKIhx48xBdDjqxHIvYaoyMTiWqyp4o4W0YlH4MTafuEjW1wANma
 e9thyyhbdRql2kcLjIAkLNRh7rGI3NT0bJboc5p71srv2TqwbbrMOZtmRo9qPFPUpAt7qFaf
 aRVaasXiIR+zLHfIoW1g7tlzdLPrW1QVvPNBOIUMA4NqKSWiQxsgzdu7Suydou3Kb4O0FHRv
 vHdfOkB07uECSZTZSdseIXOu9Ofsi6tD0hhz+7ODqknM9IFlPD32CY/H3uvbw9u5qyDAlaSV
 6b1djAVzCgc5zJM/WQx8GbH9ww5i8iG+2b/OSSGQRUOr0wxpXDKuN1gbXwZhtVVa56icKJta
 bbTyhIZZi2/XNqxPtcZxV9LTZ0+uNXcHelO8g/qFNJX0aCtAfaLwec5OZ1qppjeQ8paos13N
 JtBnH7U+0OCcH7B4Hc91I6L5qnUHQBC84MqLehw/XSBYEp56NXrRJByn9cVCoqWoD+Og4YCx
 pn0QboraBbYBg32jP8nEt3IRYWyD7hrU3szH9H+OlpCUHFhzYQARAQABtCpPbGl2ZXIgU21p
 dGggPG9sbGllcGFyYW5vaWRAYml0bWVzc2FnZS5jaD6JAk4EEwEIADgCGyMFCwkIBwIGFQgJ
 CgsCBBYCAwECHgECF4AWIQRW6FMNtYvcgBJX9fBa5/VRPgiFywUCWSCsbwAKCRBa5/VRPgiF
 y5YOEACTnQ9cb6tWuabTUduoi5UV6A1M/CU1ZnCvTVPCu72pfjn1idniAtis0Q25UfAs3FNr
 8user54eBfLB9X/6LPU97VeKrOz2j0IVDAneL99YyK2xLw02a0vVDpnhCvP1fZZEtnmt1Z/v
 DCvU2BKTNV62w3S6ZojKQqS25/gPny06seJW38P7Md7lJNwvwsjiL/j29REWRI1SYUI1N3OG
 +tSVWhNNGXNaYSLpGh481JAbp7o+xb+e9Gl+PSIyu2uThAjYcKLm32yorrK8VGMUzqf/FN1z
 9VLQWWMMTA/NFwj+HQaaFoEnUu9H2Epw/Vcz4sGanhv/Fjc3QeRfiUbCAdqFtCE1iDfmYvX+
 gODyJi2xpQ2MLTS6DOL5J3JXOIBRHPkjsDl6vuxxxjzLhWUbn4PpU/fNYap2dp1A19IH2IxR
 Ka7ClzYI8wrxW7APjbP/Ii9Md6KXTJWLQ+RGsQ8LvOTPVMXzdmqCLe3SwgSrGH9xr4pNm8qf
 PAclsuWlqyEEdWFj5080m98ZJgU0A1yHH95bmrWmhugaAydEC/uTc2tSMYrqRWzL12bAGBig
 493Vx3I9it6fECVSPdWEw7KwqK2J10X4lvryODAzg4biPnOVFQeR9Nup/HBPWv7u3oFefl+7
 1QENkMD1AIVhtrT0NMRO8qlsd8KhbVVCQTxfsWEVnbkCDQRZIKhWARAAtnQOhY4KQwU4io++
 WxmiNIKuvA5lzMDugBCK/EcY8hNjVh3L2JjgJ1izwcL2mWaUL384tyBODoAAwlShDObfc8LN
 ozIHVr0JOoblFPR6Jzi9WVq0dquqvqd8ZQu2AXiSjvyvqlqlmX3+/+duSqGa6/p/fYorpCmt
 TIkGI9CEB8ZabEtlj/rA09QhMnlkHEM9pPtzuUDhddxx7qJ6qFwtp2+WGT7Cd4fHKrnk5Yfw
 G4RxubxsFkC/3ekO/hmnqkDhM7xTOR7e5+3EHaRoYDAW6DD+QfhLnPFtSLl71G7mzQ9unvM/
 H6lWtZLb4SSqOxsNUJwY9FUkqLWnHxeC1xkVNjeRCf0ojobPxmRwG4/uQlE5UNwUolgPzYUU
 +EbZjtB1TZpD9wVILjkJrkVfdjdGjT3WTuMYbZbF3i63cq2T4jnktfW0zU6LZAsB+sn/Fbka
 SBQqN39o+1EhjPEJS5sYksPgHxpLyWgPcUaLilFnoTXAJMafj2B8Pq7yNs/izLGbrNIXvByM
 ZblbkO1SsKmDxYyV4mPDpc6nMVbIMGE5T0HVElBy8nc0kXMrRo2iidm9r2uMdIzTDK4ik8oY
 aZ1gzPCeL/+rGKA94n6heow5CKJeEb7L22DoPKYVv9JOjLhbZ2+jxZKoCe2NfyRac7PbiDgz
 tzmks+vzZFmyBSRANrsAEQEAAYkCNgQYAQgAIAIbDBYhBFboUw21i9yAElf18Frn9VE+CIXL
 BQJZIKx1AAoJEFrn9VE+CIXL84UP/3l/f77Sfn2Ldwh2h+GyK4Em20/BNgnYx5H8lvKFCswd
 2yWp4gO92rrmgnfa43Hl3x7/4Afn2WV5/kQwJL41xoJhhi3n3nOxPzXrHRi2eonLzwup09VC
 hs4Sg4Q7fHeUK+fXyKg7KgUY5LHDoYH6Md8Cuy5Er6st9Xam6daXDmkVVVQ74b2yXMfsW9h8
 yBpWjg+JSh68LZf0quevM4iLEq+qZVvRM8lzaDyVs6fAT4iNmaw/+5+RZi7aCH2PLRRIwR4f
 Ufha/MNo1nupLSnQD16kfB5DHkwbHWp96USVkYHl/lxGN55FjH1dP5TBfgAsurCjmxWxZTQp
 S+sqivEElg4j7+rpIOLCugskq8EN0Hv7j9nOaov7iB/BzubT9XHqy518/IQ0UAaNPgowpvx7
 ISd9QXpMhTSeETVgLTv4SaoZZqE2UUKVVkbF5RAt2ykF/4Iow2UEX9nyg0g3g5LW82zV6xyG
 m+XdIAoRawBe1vcS0xHfysfqEK23YTpQC4Q69yfjHknaA6rK8rvPrQJK34JWMICes6A91RpA
 51CsEVUZTIha6nkIRF2aOdZaC2NeVhbYX66YEERV2EA5Wy7Fi5ES/7/mhQRkqCj6r6Zw2Py3
 fUwz07s/NcFvqkrICZDTmCH4jydV6jUgLwzw4uf82HKwmQxPvyw1XWaK9fXUMON2
Subject: Re: [alpine-devel] Extend APKBUILD format with a variable to check
 framework versions
Message-ID: <ff73dc26-2200-9da2-cf31-d5b2130c89d0@bitmessage.ch>
Date: Thu, 14 Mar 2019 23:14:00 +0000
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20190314103123.18921d4f@ncopa-desktop.copa.dup.pw>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hello Natanael,

> I looked at the script and tested it a bit. A few general comments:>
> - Would be nice to be able to specify APORTS dir as an arg, and if its
>   omitted  (and $APORTS is empty) then use current dir.

done

> - I like that you use `find` to find the APKBUILDs
> 
> - I think we may need parse/execute the entire APKBUILD to get the
>   relgroup, so that things like relgroup=qt${pkgver%%.*} works.

So right now the script limits how the relgroup lines may look like with
a regex. It checks for any invalid relgroup lines and errors out as
necessary before it actually reads all relgroups from the APKBUILDs.
Thanks to the simple format, both steps can be done with grep and should
therefore be a lot faster than actually parsing each APKBUILD. (At least
that's my assumption. I could do some benchmarks if anybody doubts this.)

That means we would need to write 'relgroup="qt5"' in the given example.

What do you think, is this a good trade-off between speed and writing
anything you want in relgroup?

> - the script is a bit slow. Probably because there are forks for each
>   APKBUILD.

Just to clarify: it only sources the APKBUILDs where it found out with
grep, that it has a relgroup. In order to parse the pkgver properly.

On my laptop (with SSD) and a few relgroups added to Alpine's
aports.git, it takes 3.9 seconds after a fresh boot. (All subsequent
calls take about 0.4 seconds due to caching.)

I'm not sure if we could speed it up more, suggestions welcome.

> Sounds like a good idea to keep it in the alpinelinux' org. I don't
> know if we want keep it on git.alpinelinux.org? What does infra team
> think?

Not that you have asked me, but I think it is good for consistency.

Thanks for your review and testing!

Cheers,
Oliver



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---