~alpine/devel

mkinitfs.in: Fix typo leading to "sh: missing ]" error. v1 PROPOSED

Przemyslaw Pawelczyk <przemoc@zoho.com>
7 years ago 
Przemyslaw Pawelczyk: 1
 mkinitfs.in: Fix typo leading to "sh: missing ]" error.

 1 files changed, 1 insertions(+), 1 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git: 

curl -s https://lists.alpinelinux.org/~alpine/devel/patches/1070/mbox | git am -3
Learn more about email & git
Reply to thread View this thread in the archives

[alpine-devel] [PATCH] mkinitfs.in: Fix typo leading to "sh: missing ]" error. Export this patch

Przemyslaw Pawelczyk <przemoc@zoho.com>
7 years ago 
Reported-by: Duncan on #alpine-linux

Also negate test result instead of negating expression within test.
It's better to minimize test "extra" features usage.

XSI extensions specifying the -a and -o binary primaries and the '(' and
')' operators have been marked obsolescent as there are clearer shell
equivalents. Negation (!) is not marked obsolescent (at least yet),
but shell usage is preferred.
---

I think it should be applied in aports too, stable included.


 mkinitfs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkinitfs.in b/mkinitfs.in
index 0cd5d30b274c..596ae7b753e4 100755
--- a/mkinitfs.in
+++ b/mkinitfs.in
@@ -233,7 +233,7 @@ if [ -z "$outfile" ]; then
	outfile="${basedir}boot/initramfs-${kflavor}"
fi

if [ -z "$nokernel"] && [ ! -d "$kerneldir" ]; then
if [ -z "$nokernel" ] && ! [ -d "$kerneldir" ]; then
	echo "$kerneldir does not exist or is not a directory"
	exit 1
fi
-- 
2.13.5




---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---