Remove *.la files by default v2 PROPOSED

Bartłomiej Piotrowski: 2
 Remove *.la files by default
 abuild: remove *.la files by default

 2 files changed, 10 insertions(+), 12 deletions(-)

[alpine-devel] [PATCH] Remove *.la files by default Export this patch

Libtool archives are useless in the most of cases and can be safely
removed. A quick grep shows that *.la files are explicitly removed in
903 APKBUILDs, while intentionally preserved only in 17.

postcheck() is discussable place to perform the deletion, but it's
currently the only function being run for each subpackage, including
the artifact of package().
---
 abuild.in | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/abuild.in b/abuild.in
index 5459a9b..1ccb1e4 100644
--- a/abuild.in
+++ b/abuild.in
@@ -616,13 +616,12 @@ postcheck() {
 			return 1
 		fi
 	fi
-	# look for *.la files
-	i=$(find "$dir" -name '*.la' | sed "s|^$dir|\t|")
-	if [ -n "$i" ] && ! options_has "libtool"; then
-		error "Libtool archives (*.la) files found and \$options has no 'libtool' flag:"
-		echo "$i"
-		return 1
+
+	# remove *.la files if libtool is not set
+	if ! options_has "libtool"; then
+		find "$dir" -name '*.la' -type f -delete
 	fi
+
 	# look for /usr/lib/charset.alias
 	if [ -e "$dir"/usr/lib/charset.alias ] \
 			&& ! options_has "charset.alias"; then
-- 
2.1.3


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

[alpine-devel] [PATCH v2] abuild: remove *.la files by default Export this patch

Libtool archives are useless in the most of cases and can be safely
removed. A quick grep shows that *.la files are explicitly removed in
903 APKBUILDs, while intentionally preserved only in 17.

postcheck() is discussable place to perform the deletion, but it's
currently the only function being run for each subpackage, including
the artifact of package().

Natanael Copa <ncopa@alpinelinux.org>

9 years ago

I agree that postcheck is not optimal, but I don't have any better
suggestions atm either. Applied as is.

This will be included in next abuild release, 2.22.0.

Thanks!


-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

---
 abuild.in | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/abuild.in b/abuild.in
index 5459a9b..1ccb1e4 100644
--- a/abuild.in
+++ b/abuild.in
@@ -616,13 +616,12 @@ postcheck() {
 			return 1
 		fi
 	fi
-	# look for *.la files
-	i=$(find "$dir" -name '*.la' | sed "s|^$dir|\t|")
-	if [ -n "$i" ] && ! options_has "libtool"; then
-		error "Libtool archives (*.la) files found and \$options has no 'libtool' flag:"
-		echo "$i"
-		return 1
+
+	# remove *.la files if libtool is not set
+	if ! options_has "libtool"; then
+		find "$dir" -name '*.la' -type f -delete
 	fi
+
 	# look for /usr/lib/charset.alias
 	if [ -e "$dir"/usr/lib/charset.alias ] \
 			&& ! options_has "charset.alias"; then
-- 
2.1.3


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---