Some packages like fakeroot install man pages to
/usr/share/man/{de,fr,pl,...}. In my opinion we don't need those man
pages and thus I would suggest that only /usr/share/man[0-8] should
exist.
These are not non-standard locations.
They are the standard locations for non-english languages.
/usr/share/man/man[0-8] is the standard location for english manpages
(not /usr/share/man[0-8] as you say in the commit message), but your patch
gets that right.
FYI, this patch does not fix one standing issue with compressing manpages:
symlinks to manpages are not fixed to point to the compressed one.
I have pushed a fix for symlinks and hardlinks and man pages found in
other sections and localized man pages.
http://git.alpinelinux.org/cgit/abuild/commit/?id=fe2332d186cad4edc0a1b721ce657015a60c00f5
dosfstools-doc has symlinks
tcl-doc has hardlinks
It would be nice if someone could help me test it from abuild git.
There are some other improvements I'd like relatively soon so I'd like
tag a new abuild release.
Thanks!
-nc
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---
Thanks,
Isaac Dunham
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---
The check is still flawed, there are still things like *.[0-9]pm and
*.[0.9]p. And as Isaac mentioned, we need to deal with symlinks too.
I wonder if we should look for an external tool to help us do the
compression.
---
abuild.in | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/abuild.in b/abuild.in
index 6d393c8..da83ca1 100644
--- a/abuild.in+++ b/abuild.in
@@ -655,13 +655,20 @@ postcheck() {
if ! is_doc_pkg "$name"; then
warning "Found /usr/share/man but package name doesn't end with -doc"
fi
- # check for uncompressed man pages- i=$(find "$dir"/usr/share/man -name '*.[0-9]' -type f | sed "s|^$dir|\t|")+ # check for man pages in non-standard locations+ i=$(find "$dir"/usr/share/man -maxdepth 1 \! \( -name man[0-8] -a -type d \) -a \! -path "$dir"/usr/share/man | sed "s|^$dir|\t|") if [ -n "$i" ]; then
- error "Found uncompressed man pages:"- echo "$i"+ error "Found non-standard man page sections:"+ echo $i
return 1
fi
+ # check for uncompressed man pages+ for i in "$dir"/usr/share/man/man[0-8]/*.[0-8]; do+ if [ -e "$i" ]; then+ error "Found uncompressed man pages: ${i#$dir/}"+ return 1+ fi+ done fi
# check directory permissions
i=$(find "$dir" -type d -perm -777 | sed "s|^$dir|\t|")