MIME-Version: 1.0
References: <CADtgU8WLg6+_UgoO+F-jCF6F8hdzxO8KWmwqX7UXS9P=a9=zaw@mail.gmail.com>
In-Reply-To: <CADtgU8WLg6+_UgoO+F-jCF6F8hdzxO8KWmwqX7UXS9P=a9=zaw@mail.gmail.com>
From: Konstantin Kulikov <k.kulikov2@gmail.com>
Date: Tue, 29 Mar 2022 15:55:28 +0300
Message-ID: <CAD+eXGQ91CZ3wvJ4wHtQbBJsX29D9hi+r32nHMNphbEcpbXSjw@mail.gmail.com>
Subject: Re: issue with grafana alpine package config
To: Sergio Valentini <savalentini@gmail.com>, ~alpine/users@lists.alpinelinux.org
Content-Type: text/plain; charset="UTF-8"

+ ~alpine/users

Hi.

>I just don't know how else to report this
Issues with packages are to be reported on gitlab
https://gitlab.alpinelinux.org/alpine/aports/-/issues

>some values hard-coded into conf.d
conf.d files are supposed to be edited by admins. Removing that line
is the right solution for your problem.

>Would you be open to removing this line from the conf.d file?
It's not ok for unsecured services in default configuration to listen
on all interfaces. So no.

There were several considerations to put those settings in conf.d
instead of grafana.ini:
1. init.d script has to create data directories and set their
permissions, that means path to data dir needs to be a variable
(GRAFANA_HOME)
2. grafana.ini didn't support envvar expansion until 7.1 (or at least
it wasn't documented)
3. log.mode=syslog requires rc_need=logger. I like when related
settings are located together
4. all that leaves listen address, I decided not to patch config file
for that one option

It is possible to move those settings to grafana.ini, but it is a lot
of work for very little profit, as well as annoying "WARNING: please
migrate to new config file" for every single user of this package. And
I'm against migrating config in a backwards incompatible way.

On Mon, Mar 28, 2022 at 7:17 AM Sergio Valentini <savalentini@gmail.com> wrote:
>
> Hey so sorry to bother you via email, I just don't know how else to report this.
> I noticed that your package has some values hard-coded into conf.d, like:
>
> cfg:server.http_addr=127.0.0.1
>
>
> So no matter what one puts on /etc/grafana.ini the server will only accept connections from itself.
>
> People who are not familiar with init.d may have a hard time figuring out why they can't connect to the server.
>
> Commenting this line out fixes the problem. Would you be open to removing this line from the conf.d file?
>
>
> Thanks!
>
>
> Sergio