Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id BB063781557 for <~alpine/users@lists.alpinelinux.org>; Fri, 1 Apr 2022 16:20:43 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id v12so4601829ljd.3 for <~alpine/users@lists.alpinelinux.org>; Fri, 01 Apr 2022 09:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jxY6UZCU05/7J4RYqr3I6PE4/8wFLbYamie0X9EEzPc=; b=ZTCdcu/J7wNBxM0BnUik7fGkOiLEX8ZQnu0MxRvGjQld6uk1XQmTiEHjpzd74WwtgC KIiZY3UBBe6AyW3DUbDA1n8PDMBasL/+xpUPgsMggjEehdmdXJaOt2C4cvTntBQ3LQ7n 0KL7nlQfyQb1ZqJlUHPAq3tU8LFfkz8h/eiMC/sA9AhEB5JWLJ+FbXV6Eox4xfa4npJ1 Qci4AuAN2xLgUZXaBbDlou4PXmFtImPs4uMkVzyJ38QXX3PLw5mXb6i8Og3sqfBpISXP wyFlscN9WBN1BsdlkKy/7Eq+HOqu+PqfYLLxgy/lGLLWPMHhkcuvIprfm1l99rGEaKSN +9kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jxY6UZCU05/7J4RYqr3I6PE4/8wFLbYamie0X9EEzPc=; b=woOdtOs8h4SkCkLwamJQnkui/rPjtKYtwqRAb8WbZ/P1V9J+IAYVu5gFFLtx6JyF0c Eh54/+XT7FyNUWyZeW1zQsmrgMSu/ICRFboaTLow9ZkkeWJyPY+tJJuo0LyUZFp58GJj fsVdzFyFa7odj8lx8+7vdoTP+z4s8QfrfoMjvrcpvYPyawD28D0tCyad6ewRhFdMWQJi vnll/y1kZpUIzlDFUMV40SzwPecH90gI/4bivks50D7dOm4lIg5sJTPWehxE7FDD7i9T CsXn4dhPJRAj9WftGRS1ab1VOo+s2Ra7gbFvvCzeZUQ9zepyxfaOY6LU46ARt4Jewo0r ybBA== X-Gm-Message-State: AOAM530//S1waxZzGwlqc037GcC6vcMgdmKh7IQ6TU68t1ul3L/ezX4k ZDS8MJa9b1dC7UImr/aFKJapYh7r7WYy1D6+a9k= X-Google-Smtp-Source: ABdhPJw2h2QOWwum/gRrP/lMmYABoePTW1wlAMjcVut3J6seh3VupnJ9/4ZLNG+BfSlSigoqLdGuIUJG+zxQi3lBfuk= X-Received: by 2002:a2e:8e82:0:b0:249:808b:58f1 with SMTP id z2-20020a2e8e82000000b00249808b58f1mr13814948ljk.91.1648830042359; Fri, 01 Apr 2022 09:20:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sergio Valentini Date: Fri, 1 Apr 2022 09:21:18 -0700 Message-ID: Subject: Re: issue with grafana alpine package config To: Konstantin Kulikov Cc: ~alpine/users@lists.alpinelinux.org Content-Type: multipart/alternative; boundary="000000000000f84d1b05db9a288c" --000000000000f84d1b05db9a288c Content-Type: text/plain; charset="UTF-8" Hey thanks for taking the time to respond. Very informative, now I understand the reasoning behind these choices. Take care, Sergio On Tue, Mar 29, 2022 at 5:55 AM Konstantin Kulikov wrote: > + ~alpine/users > > Hi. > > >I just don't know how else to report this > Issues with packages are to be reported on gitlab > https://gitlab.alpinelinux.org/alpine/aports/-/issues > > >some values hard-coded into conf.d > conf.d files are supposed to be edited by admins. Removing that line > is the right solution for your problem. > > >Would you be open to removing this line from the conf.d file? > It's not ok for unsecured services in default configuration to listen > on all interfaces. So no. > > There were several considerations to put those settings in conf.d > instead of grafana.ini: > 1. init.d script has to create data directories and set their > permissions, that means path to data dir needs to be a variable > (GRAFANA_HOME) > 2. grafana.ini didn't support envvar expansion until 7.1 (or at least > it wasn't documented) > 3. log.mode=syslog requires rc_need=logger. I like when related > settings are located together > 4. all that leaves listen address, I decided not to patch config file > for that one option > > It is possible to move those settings to grafana.ini, but it is a lot > of work for very little profit, as well as annoying "WARNING: please > migrate to new config file" for every single user of this package. And > I'm against migrating config in a backwards incompatible way. > > On Mon, Mar 28, 2022 at 7:17 AM Sergio Valentini > wrote: > > > > Hey so sorry to bother you via email, I just don't know how else to > report this. > > I noticed that your package has some values hard-coded into conf.d, like: > > > > cfg:server.http_addr=127.0.0.1 > > > > > > So no matter what one puts on /etc/grafana.ini the server will only > accept connections from itself. > > > > People who are not familiar with init.d may have a hard time figuring > out why they can't connect to the server. > > > > Commenting this line out fixes the problem. Would you be open to > removing this line from the conf.d file? > > > > > > Thanks! > > > > > > Sergio > --000000000000f84d1b05db9a288c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey thanks for taking the time to respond. Very informativ= e, now I understand the reasoning behind these choices.

= Take care,

Sergio



On T= ue, Mar 29, 2022 at 5:55 AM Konstantin Kulikov <k.kulikov2@gmail.com> wrote:
+ ~alpine/users

Hi.

>I just don't know how else to report this
Issues with packages are to be reported on gitlab
https://gitlab.alpinelinux.org/alpine/aports/-/= issues

>some values hard-coded into conf.d
conf.d files are supposed to be edited by admins. Removing that line
is the right solution for your problem.

>Would you be open to removing this line from the conf.d file?
It's not ok for unsecured services in default configuration to listen on all interfaces. So no.

There were several considerations to put those settings in conf.d
instead of grafana.ini:
1. init.d script has to create data directories and set their
permissions, that means path to data dir needs to be a variable
(GRAFANA_HOME)
2. grafana.ini didn't support envvar expansion until 7.1 (or at least it wasn't documented)
3. log.mode=3Dsyslog requires rc_need=3Dlogger. I like when related
settings are located together
4. all that leaves listen address, I decided not to patch config file
for that one option

It is possible to move those settings to grafana.ini, but it is a lot
of work for very little profit, as well as annoying "WARNING: please migrate to new config file" for every single user of this package. And=
I'm against migrating config in a backwards incompatible way.

On Mon, Mar 28, 2022 at 7:17 AM Sergio Valentini <savalentini@gmail.com> wrote: >
> Hey so sorry to bother you via email, I just don't know how else t= o report this.
> I noticed that your package has some values hard-coded into conf.d, li= ke:
>
> cfg:server.http_addr=3D127.0.0.1
>
>
> So no matter what one puts on /etc/grafana.ini the server will only ac= cept connections from itself.
>
> People who are not familiar with init.d may have a hard time figuring = out why they can't connect to the server.
>
> Commenting this line out fixes the problem. Would you be open to remov= ing this line from the conf.d file?
>
>
> Thanks!
>
>
> Sergio
--000000000000f84d1b05db9a288c--