Subject: Re: [alpine-user] missing header sys/queue.h
To: alpine-user@lists.alpinelinux.org
References: <18833665-ea51-febd-5695-5098b5986135@libero.it>
 <AM4PR0701MB2273870DD00BD3F0650C7A7EEE750@AM4PR0701MB2273.eurprd07.prod.outlook.com>
 <69dc00e5-7e32-1a6a-0cf8-71bf675c15bd@libero.it>
 <c3c9691c-23b5-839e-3856-b7b16add8022@toastin.space>
 <c303c9a1-0aa6-46e7-571a-a97214b5f607@libero.it>
 <8bcf5e42-3654-0454-19e7-5d76bba0b925@toastin.space>
 <a0b2090f-e279-4b45-607b-e8e3fa975a50@libero.it>
 <8add8700-d296-5806-5a41-c768af81d4b9@toastin.space>
From: Riccardo Mottola <riccardo.mottola@libero.it>
Message-ID: <bf7d00b6-b50f-56c9-1f6e-087f1b5c79c4@libero.it>
Date: Fri, 8 Mar 2019 14:27:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Firefox/52.0 SeaMonkey/2.49.4
Precedence: list
MIME-Version: 1.0
In-Reply-To: <8add8700-d296-5806-5a41-c768af81d4b9@toastin.space>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Natanael & Chloe,

Chloe Kudryavtsev wrote:
> BLOCK_SIZE is canonically defined in linux/fs.h as (1 << 
> BLOCK_SIZE_BITS).
>
> Glibc coincidentally redefines it to a hardcoded 1024 in sys/mount.h, 
> but this is a glibc-specific extension.
>
> Please make sure your project includes the correct header.
>
> Also, do note that searching for "musl BLOCK_SIZE" (at least from 
> where I'm at) gives relevant results in the top two slots (I haven't 
> checked much lower). 

thanks for the pointers, I found actually this discussion upstream

https://bugzilla.mozilla.org/show_bug.cgi?id=1152176

which shows some discussion if fs.h or mount.h is the better option.

At the end, FF opted for the solution to conditionally hard-code 1024. I 
will see if this fix solves the issue.

While ArcticFox is a fork and technically I can fix it differently, I 
prefer, when possible to have similar soruces, since it facilitates 
maintenance. I will test and let you know!


Happy hacking,
Riccardo



---
Unsubscribe:  alpine-user+unsubscribe@lists.alpinelinux.org
Help:         alpine-user+help@lists.alpinelinux.org
---