~alpine/devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[alpine-devel] [PATCH] sems: create var/run/sems dir on install

Nathan Angelacos <nangel@alpinelinux.org>
Details
Message ID
<1304340206-3070-1-git-send-email-nangel@alpinelinux.org>
Sender timestamp
1304340206
DKIM signature
missing
Download raw message
Patch: +1 -0
---
 testing/sems/APKBUILD |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/testing/sems/APKBUILD b/testing/sems/APKBUILD
index 49a61ad..d9cb870 100644
--- a/testing/sems/APKBUILD
+++ b/testing/sems/APKBUILD
@@ -76,6 +76,7 @@ package() {
	rm -f "$pkgdir"/etc/sems/etc/conf_auth.conf

	install -o sems -g sems -d "$pkgdir"/var/spool/voicebox
	install -d -o sems  "$pkgdir"/var/run/sems
}

_mv_sub() {
-- 
1.7.4.4



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

[alpine-devel] Re: [PATCH] sems: create var/run/sems dir on install

Nathan Angelacos <nangel@nothome.org>
Details
Message ID
<4DBE38A0.5030008@nothome.org>
In-Reply-To
<1304340206-3070-1-git-send-email-nangel@alpinelinux.org> (view parent)
Sender timestamp
1304311968
DKIM signature
missing
Download raw message
After this patch, sems 1.4.0  (and related subpackages) are ready for 
main IMHO.

On 05/02/2011 05:43 AM, Nathan Angelacos wrote:
> ---
>   testing/sems/APKBUILD |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/testing/sems/APKBUILD b/testing/sems/APKBUILD
> index 49a61ad..d9cb870 100644
> --- a/testing/sems/APKBUILD
> +++ b/testing/sems/APKBUILD
> @@ -76,6 +76,7 @@ package() {
>   	rm -f "$pkgdir"/etc/sems/etc/conf_auth.conf
>
>   	install -o sems -g sems -d "$pkgdir"/var/spool/voicebox
> +	install -d -o sems  "$pkgdir"/var/run/sems
>   }
>
>   _mv_sub() {



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

Re: [alpine-devel] Re: [PATCH] sems: create var/run/sems dir on install

Nathan Angelacos <nangel@nothome.org>
Details
Message ID
<4DBEB990.8060303@nothome.org>
In-Reply-To
<20110502082126.2691cc79@ncopa-desktop.nor.wtbts.net> (view parent)
Sender timestamp
1304344976
DKIM signature
missing
Download raw message
On 05/01/2011 11:21 PM, Natanael Copa wrote:
> On Sun, 01 May 2011 21:52:48 -0700
> Nathan Angelacos<nangel@nothome.org>  wrote:
>
>> After this patch, sems 1.4.0  (and related subpackages) are ready for
>> main IMHO.
>
> Its a little late in the game, but I suppose there are not too many who
> uses it in production from v2.2 (if any). I think we do an exception
> and add it to main for includsion in v2.2. Its kinda nice to have a
> recent version since we will maintain it for some time.
>
> Thanks!

No problem on not adding to v2.2 if you think its too late v2.3 is ok - 
but it should at least be in edge main, and not edge testing.


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20110502081915.074b4bbe@ncopa-desktop.nor.wtbts.net>
In-Reply-To
<1304340206-3070-1-git-send-email-nangel@alpinelinux.org> (view parent)
Sender timestamp
1304317155
DKIM signature
missing
Download raw message
On Mon,  2 May 2011 12:43:26 +0000
Nathan Angelacos <nangel@alpinelinux.org> wrote:

> ---
>  testing/sems/APKBUILD |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/testing/sems/APKBUILD b/testing/sems/APKBUILD
> index 49a61ad..d9cb870 100644
> --- a/testing/sems/APKBUILD
> +++ b/testing/sems/APKBUILD
> @@ -76,6 +76,7 @@ package() {
>  	rm -f "$pkgdir"/etc/sems/etc/conf_auth.conf
>  
>  	install -o sems -g sems -d "$pkgdir"/var/spool/voicebox
> +	install -d -o sems  "$pkgdir"/var/run/sems
>  }
>  
>  _mv_sub() {

Is this really needed? I think we create the dir from init.d script in
case /var/run happens to be a tmpfs mount (yeah, we probably need a
major cleanup in lots of init.d scripts to get that actually working)

Secondly, always bump pkgrel when contents of package changes.
Otherwise it will not be rebuilt. And even if it would, people who has
it installed will not have it upgraded unless pkgver/pkgrel changes.

I applied it anyways and bumped pkgrel.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

Re: [alpine-devel] Re: [PATCH] sems: create var/run/sems dir on install

Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20110502082126.2691cc79@ncopa-desktop.nor.wtbts.net>
In-Reply-To
<4DBE38A0.5030008@nothome.org> (view parent)
Sender timestamp
1304317286
DKIM signature
missing
Download raw message
On Sun, 01 May 2011 21:52:48 -0700
Nathan Angelacos <nangel@nothome.org> wrote:

> After this patch, sems 1.4.0  (and related subpackages) are ready for 
> main IMHO.

Its a little late in the game, but I suppose there are not too many who
uses it in production from v2.2 (if any). I think we do an exception
and add it to main for includsion in v2.2. Its kinda nice to have a
recent version since we will maintain it for some time.

Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)