On 2016-03-01 1:36 AM, Timo Teras wrote:
> On Fri, 26 Feb 2016 04:16:41 -0500> Muh Muhten <muh.muhten@gmail.com> wrote:]>> --->> +_split() {>> + install_if="lua$1 $pkgname=$pkgver-r$pkgrel">> + pkgdesc="$pkgdesc for Lua $1">> +>> + cd "$_builddir">> + install -Dm644 fun.lua "$subpkgdir/usr/share/lua/$1/fun.lua">> || return 1 +}>> It's the same file installed in three separate packages - just to> separate directory.>> I wonder if we should ship this in some common folder. @ncopa Do we> have any shared lua path that would be usable in all lua versions?> Or should this be single package that provides all three files and just> ships symlinks/hardlinks?
Yes, it's unfortunate. Some light inspection (see below) suggests that
*all* lua libs get installed under versioned dirs. Most of our lua
packages seemed to work this way. I don't think hardlinks are a viable
solution, since the versions get split into separate tarballs, which we
can't practically annotate to indicate hardlinks. symlink is at least
possible, but it's not clear how to organise.
% for ea in 5.1 jit 5.2 5.3; do lua$ea -e
"print('lua$ea:\t'..package.path)"; done | sed 's/;/\n\t/g'
lua5.1: ./?.lua
/usr/local/share/lua/5.1/?.lua
/usr/local/share/lua/5.1/?/init.lua
/usr/local/lib/lua/5.1/?.lua
/usr/local/lib/lua/5.1/?/init.lua
/usr/share/lua/5.1/?.lua
/usr/share/lua/5.1/?/init.lua
luajit: ./?.lua
/usr/share/luajit-2.0.4/?.lua
/usr/local/share/lua/5.1/?.lua
/usr/local/share/lua/5.1/?/init.lua
/usr/share/lua/5.1/?.lua
/usr/share/lua/5.1/?/init.lua
lua5.2: /usr/local/share/lua/5.2/?.lua
/usr/local/share/lua/5.2/?/init.lua
/usr/share/lua/5.2/?.lua
/usr/share/lua/5.2/?/init.lua
/usr/local/lib/lua/5.2/?.lua
/usr/local/lib/lua/5.2/?/init.lua
./?.lua
/usr/lib/lua/5.2/?.lua
/usr/lib/lua/5.2/?/init.lua
./?.lua
lua5.3: /usr/local/share/lua/5.3/?.lua
/usr/local/share/lua/5.3/?/init.lua
/usr/local/lib/lua/5.3/?.lua
/usr/local/lib/lua/5.3/?/init.lua
/usr/share/lua/5.3/?.lua
/usr/share/lua/5.3/?/init.lua
/usr/lib/lua/5.3/?.lua
/usr/lib/lua/5.3/?/init.lua
./?.lua
./?/init.lua
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On Fri, 26 Feb 2016 04:16:41 -0500
Muh Muhten <muh.muhten@gmail.com> wrote:
> http://rtsisyk.github.io/luafun/> "Lua Fun is a high-performance functional programming library for Lua> designed with LuaJIT's trace compiler in mind."
Looks good... but see below.
> ---> +_split() {> + install_if="lua$1 $pkgname=$pkgver-r$pkgrel"> + pkgdesc="$pkgdesc for Lua $1"> +> + cd "$_builddir"> + install -Dm644 fun.lua "$subpkgdir/usr/share/lua/$1/fun.lua"> || return 1 +}
It's the same file installed in three separate packages - just to
separate directory.
I wonder if we should ship this in some common folder. @ncopa Do we
have any shared lua path that would be usable in all lua versions?
Or should this be single package that provides all three files and just
ships symlinks/hardlinks?
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
Sorry for late answer
On Tue, 1 Mar 2016 01:57:54 -0500
Muh Muhten <muh.muhten@gmail.com> wrote:
> On 2016-03-01 1:36 AM, Timo Teras wrote:> > On Fri, 26 Feb 2016 04:16:41 -0500> > Muh Muhten <muh.muhten@gmail.com> wrote:] > >> ---> >> +_split() {> >> + install_if="lua$1 $pkgname=$pkgver-r$pkgrel"> >> + pkgdesc="$pkgdesc for Lua $1"> >> +> >> + cd "$_builddir"> >> + install -Dm644 fun.lua "$subpkgdir/usr/share/lua/$1/fun.lua"> >> || return 1 +} > >> > It's the same file installed in three separate packages - just to> > separate directory.> >> > I wonder if we should ship this in some common folder. @ncopa Do we> > have any shared lua path that would be usable in all lua versions?
I have a shared /usr/share/lua/common dir for lua-penlight. Then the
lua5.[123]-penlight packages have symlinks to this common dir.
> > Or should this be single package that provides all three files and just> > ships symlinks/hardlinks?
I think it depends on how big the file is and how likely it is that you
will have it installed for more than one lua version at the same time.
penlight is relatively big (450kb) so in that case the extra package
overhead for a lua-penlight-shared package is worth it.
> Yes, it's unfortunate. Some light inspection (see below) suggests that > *all* lua libs get installed under versioned dirs. Most of our lua > packages seemed to work this way. I don't think hardlinks are a viable > solution, since the versions get split into separate tarballs, which we > can't practically annotate to indicate hardlinks. symlink is at least > possible, but it's not clear how to organise.
lua-fun seems to be a single file, 32k, so I don't think its worth the
extra effort to ship a -shared package for it.
I just pushed it as it was submitted.
Thanks!
-nc
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---