~alpine/aports

4 3

[alpine-aports] [PATCH] community/py-ansi2html: move from testing

Details
Message ID
<20190311190126.358-1-sir@cmpwn.com>
Sender timestamp
1552330886
DKIM signature
missing
Download raw message
Patch: +0 -0
---
 {testing => community}/py-ansi2html/APKBUILD | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename {testing => community}/py-ansi2html/APKBUILD (100%)

diff --git a/testing/py-ansi2html/APKBUILD b/community/py-ansi2html/APKBUILD
similarity index 100%
rename from testing/py-ansi2html/APKBUILD
rename to community/py-ansi2html/APKBUILD
-- 
2.21.0



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<CAGG_d8CLTVFijPO8vONqvxmQMRKyZsQ7z28b3FNuD=QDm8U8hA@mail.gmail.com>
In-Reply-To
<20190311190126.358-1-sir@cmpwn.com> (view parent)
Sender timestamp
1554281322
DKIM signature
missing
Download raw message
Hi,

On Mon, Mar 11, 2019 at 8:01 PM Drew DeVault <sir@cmpwn.com> wrote:

> ---
>  {testing => community}/py-ansi2html/APKBUILD | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {testing => community}/py-ansi2html/APKBUILD (100%)
>
>
we are getting rid of python2 packages, and its prefix has been renamed to
py3. Also the packages is missing check() if tests are available or it
needs to be explicitly disabled before moving into community.

Would please submit a new patch?

Thanks!

/eo
Details
Message ID
<20190403145007.GA22791@homura.localdomain>
In-Reply-To
<CAGG_d8CLTVFijPO8vONqvxmQMRKyZsQ7z28b3FNuD=QDm8U8hA@mail.gmail.com> (view parent)
Sender timestamp
1554303007
DKIM signature
missing
Download raw message
On 2019-04-03 10:48 AM, Leonardo Arena wrote:
> we are getting rid of python2 packages, and its prefix has been renamed to
> py3. Also the packages is missing check() if tests are available or it
> needs to be explicitly disabled before moving into community.

We haven't come to consensus on how to proceed with Python 2 deprecation
yet (I was leading that effort, will hopefully get it rolling soon), so
I'd rather not drop it for now. Especially since this package already
has python2 support, and dropping it is a breaking change, I'd rather
hold off until consensus on the Python 2 problem is reached.

This package also has a check() function. Are you looking at the right
patch version? v3 is here:

https://patchwork.alpinelinux.org/patch/4609/

I think this patch hits all fo the marks. Let me know if I missed
something.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Details
Message ID
<20190408224539.GE5215@homura.localdomain>
In-Reply-To
<20190408224416.GA32083@localhost> (view parent)
Sender timestamp
1554763540
DKIM signature
missing
Download raw message
On 2019-04-08 11:44 PM, Keith Maxwell wrote:
> +options="!check" # upstream tests don't work unless module is installed
> 
> I haven't tried building the package, but what I read in the reference
> suggests this will stop the tests running:
> https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#options

My mistake. Still, the comment there should speak for itself. The patch
is suitable for inclusion imo.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Details
Message ID
<20190408224416.GA32083@localhost>
In-Reply-To
<20190403145007.GA22791@homura.localdomain> (view parent)
Sender timestamp
1554763456
DKIM signature
missing
Download raw message
Hello Drew

On Wed, Apr 03, 2019 at 10:50:07AM -0400, Drew DeVault wrote:
> This package also has a check() function. Are you looking at the right
> patch version? v3 is here:
> 
> https://patchwork.alpinelinux.org/patch/4609/
> 
> I think this patch hits all fo the marks. Let me know if I missed
> something.

I agree the patch has a check function, but I think it also includes the
line:

+options="!check" # upstream tests don't work unless module is installed

I haven't tried building the package, but what I read in the reference
suggests this will stop the tests running:
https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#options

-- 
Kind Regards

Keith Maxwell


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)