On Mon, 6 May 2013 00:31:00 +0000
Nathan Angelacos <nangel@alpinelinux.org> wrote:
> New package for unicode string handling
Applied thanks!
A few nitpicks below...
> ---> main/libunistring/APKBUILD | 41 +++++++++++++++++++++++++++++++++++++++++> 1 file changed, 41 insertions(+)> create mode 100644 main/libunistring/APKBUILD> > diff --git a/main/libunistring/APKBUILD b/main/libunistring/APKBUILD> new file mode 100644> index 0000000..48390ff> --- /dev/null> +++ b/main/libunistring/APKBUILD> @@ -0,0 +1,41 @@> +# Contributor:> +# Maintainer: Nathan Angelacos <nangel@alpinelinux.org>> +pkgname=libunistring> +pkgver=0.9.3> +pkgrel=0> +pkgdesc="GNU Unicode string library"> +url="http://www.gnu.org/software/libunistring/"> +arch="all"> +license="LGPLv3+"> +depends=""> +depends_dev="libiconv-dev"
Does libiconv-dev need to be installed to be able to compile/link against libunistring? If not, you could have depends_dev empty and add libiconv-dev to makedepends. (As it it is now libunistring-dev depends on libiconv-dev)
> +makedepends="$depends_dev"> +install=""> +subpackages="$pkgname-dev $pkgname-doc"> +source="http://ftp.gnu.org/gnu/libunistring/$pkgname-$pkgver.tar.gz"
...
> +md5sums="db8eca3b64163abadf8c40e5cecc261f libunistring-0.9.3.tar.gz"
Looks like an old abuild was used. I think we want sha256 and sha512 sums too.
-nc
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---