6 4

[alpine-aports] [PATCH] testing/openconnect: new aport

PAN, Myautsai
Details
Message ID
<1442078171-36189-1-git-send-email-myautsai@gmail.com>
Sender timestamp
1442078171
DKIM signature
missing
Download raw message
Patch: +33 -0
From: mckelvin <mckelvin@users.noreply.github.com>

http://www.infradead.org/openconnect/
Open client for Cisco AnyConnect VPN
---
 testing/openconnect/APKBUILD | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 testing/openconnect/APKBUILD

diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
new file mode 100644
index 0000000..4bdc4f2
--- /dev/null
+++ b/testing/openconnect/APKBUILD
@@ -0,0 +1,33 @@
+# Contributor: Myautsai PAN <myautsai@gmail.com>
+# Maintainer: Myautsai PAN <myautsai@gmail.com>
+
+pkgname=openconnect
+pkgver=7.06
+pkgrel=2
+pkgdesc="Open client for Cisco AnyConnect VPN"
+url="http://www.infradead.org/openconnect/"
+arch="all"
+license="LGPL2.1"
+depends="libxml2 gnutls libproxy vpnc krb5 lz4 openssl"
+depends_dev="libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev lz4-dev openssl-dev gettext"
+makedepends="intltool python"
+install=""
+source="ftp://ftp.infradead.org/pub/$pkgname/$pkgname-$pkgver.tar.gz"
+
+_builddir=$srcdir/$pkgname-$pkgver
+build() {
+    cd $_builddir
+    ./configure --prefix=/usr \
+        --sbindir=/usr/bin \
+        --disable-static
+    make
+}
+
+package() {
+    cd $_builddir
+    make DESTDIR="$pkgdir" install
+}
+
+md5sums="80f397911e1fed43d897d99be3d5f1a1  openconnect-7.06.tar.gz"
+sha256sums="facf695368dc4537a6a30e2147be90b1d77ee3cb2d269eaef070b6d9ddab70f2  openconnect-7.06.tar.gz"
+sha512sums="d1af9efe4ac1f6671dc6b92db0df981e8cae3f2f50b8b4c35a112b42a76517b7c8ea9fd5da93352445dd61da3012bf34fdbcc3add9d8727cbaad7d311e516108  openconnect-7.06.tar.gz"
-- 
2.4.6



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20150915103742.6a398cac@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1442078171-36189-1-git-send-email-myautsai@gmail.com> (view parent)
Sender timestamp
1442306262
DKIM signature
missing
Download raw message
On Sun, 13 Sep 2015 01:16:11 +0800
"PAN, Myautsai" <myautsai@gmail.com> wrote:

> From: mckelvin <mckelvin@users.noreply.github.com>
> 
> http://www.infradead.org/openconnect/
> Open client for Cisco AnyConnect VPN
> ---
>  testing/openconnect/APKBUILD | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 testing/openconnect/APKBUILD

Thanks for this patch, but it does not build:

checking for OPENSSL... no
checking for OpenSSL without pkg-config... no
configure: error: Could not build against OpenSSL
make: *** No targets specified and no makefile found.  Stop.


> 
> diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
> new file mode 100644
> index 0000000..4bdc4f2
> --- /dev/null
> +++ b/testing/openconnect/APKBUILD
> @@ -0,0 +1,33 @@
> +# Contributor: Myautsai PAN <myautsai@gmail.com>
> +# Maintainer: Myautsai PAN <myautsai@gmail.com>
> +
> +pkgname=openconnect
> +pkgver=7.06
> +pkgrel=2
> +pkgdesc="Open client for Cisco AnyConnect VPN"
> +url="http://www.infradead.org/openconnect/"
> +arch="all"
> +license="LGPL2.1"
> +depends="libxml2 gnutls libproxy vpnc krb5 lz4 openssl"

abuild will automatically pull in the needed runtime dependencies for
shared libraries so you will most likely not need the libxml2, gnutls
etc dependencies listed there.

> +depends_dev="libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev lz4-dev openssl-dev gettext"
> +makedepends="intltool python"

depends_dev will only be added as dependency for a -dev subpackage.
Since there are no subpackages in this case, the depends_dev is
meaningless.

I believe you need to move all the packages in depends_dev to makedepends.

I am also not sure if gettext dep is needed?

Care to send a v2 patch?

http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

[alpine-aports] [PATCH v2] testing/openconnect: new aport

PAN, Myautsai
Details
Message ID
<1444221059-5468-1-git-send-email-myautsai@gmail.com>
In-Reply-To
<1442078171-36189-1-git-send-email-myautsai@gmail.com> (view parent)
Sender timestamp
1444221059
DKIM signature
missing
Download raw message
Patch: +34 -0
From: mckelvin <mckelvin@users.noreply.github.com>

http://www.infradead.org/openconnect/
Open client for Cisco AnyConnect VPN
---
 testing/openconnect/APKBUILD | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 testing/openconnect/APKBUILD

diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
new file mode 100644
index 0000000..f8c6bd0
--- /dev/null
+++ b/testing/openconnect/APKBUILD
@@ -0,0 +1,34 @@
+# Contributor: Myautsai PAN <myautsai@gmail.com>
+# Maintainer: Myautsai PAN <myautsai@gmail.com>
+
+pkgname=openconnect
+pkgver=7.06
+pkgrel=2
+pkgdesc="Open client for Cisco AnyConnect VPN"
+url="http://www.infradead.org/openconnect/"
+arch="all"
+license="LGPL2.1"
+depends="libxml2 libproxy vpnc krb5 lz4 openssl"
+makedepends="autoconf automake intltool python openssl-dev libxml2-dev lz4-dev libproxy-dev"
+source="ftp://ftp.infradead.org/pub/$pkgname/$pkgname-$pkgver.tar.gz"
+
+_builddir=$srcdir/$pkgname-$pkgver
+build() {
+    cd $_builddir
+    ./configure --prefix=/usr \
+        --sbindir=/usr/bin \
+        --disable-static \
+        --without-gnutls \
+        --disable-nls
+    sed -i -r 's/\/\* #undef ICONV_CONST \*\//#define ICONV_CONST/' config.h
+    make
+}
+
+package() {
+    cd $_builddir
+    make DESTDIR="$pkgdir" install
+}
+
+md5sums="80f397911e1fed43d897d99be3d5f1a1  openconnect-7.06.tar.gz"
+sha256sums="facf695368dc4537a6a30e2147be90b1d77ee3cb2d269eaef070b6d9ddab70f2  openconnect-7.06.tar.gz"
+sha512sums="d1af9efe4ac1f6671dc6b92db0df981e8cae3f2f50b8b4c35a112b42a76517b7c8ea9fd5da93352445dd61da3012bf34fdbcc3add9d8727cbaad7d311e516108  openconnect-7.06.tar.gz"
-- 
2.4.6



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Myautsai PAN
Details
Message ID
<68E15DF47C014DD1BF1681D8AE7BFDB4@gmail.com>
In-Reply-To
<20150915103742.6a398cac@ncopa-desktop.alpinelinux.org> (view parent)
Sender timestamp
1444221791
DKIM signature
missing
Download raw message
Dear Natanael, 

Sorry about my delay.

http://patchwork.alpinelinux.org/patch/562/ is the old patch. I updated the patch by instruction in http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch . But somehow [a new patch](http://patchwork.alpinelinux.org/patch/684/ ) is created. I'm not sure whether I'm doing the right thing. If not so, please close #562 and just use #684.

Personally I strongly suggest immigrating from patchwork to GitHub and use the PR-mode. 

-- 
Myautsai PAN
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Tuesday, September 15, 2015 at 16:37, Natanael Copa wrote:

> On Sun, 13 Sep 2015 01:16:11 +0800
> "PAN, Myautsai" <myautsai@gmail.com (mailto:myautsai@gmail.com)> wrote:
> 
> > From: mckelvin <mckelvin@users.noreply.github.com (mailto:mckelvin@users.noreply.github.com)>
> > 
> > http://www.infradead.org/openconnect/
> > Open client for Cisco AnyConnect VPN
> > ---
> > testing/openconnect/APKBUILD | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644 testing/openconnect/APKBUILD
> > 
> 
> 
> Thanks for this patch, but it does not build:
> 
> checking for OPENSSL... no
> checking for OpenSSL without pkg-config... no
> configure: error: Could not build against OpenSSL
> make: *** No targets specified and no makefile found. Stop.
> 
> 
> > 
> > diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
> > new file mode 100644
> > index 0000000..4bdc4f2
> > --- /dev/null
> > +++ b/testing/openconnect/APKBUILD
> > @@ -0,0 +1,33 @@
> > +# Contributor: Myautsai PAN <myautsai@gmail.com (mailto:myautsai@gmail.com)>
> > +# Maintainer: Myautsai PAN <myautsai@gmail.com (mailto:myautsai@gmail.com)>
> > +
> > +pkgname=openconnect
> > +pkgver=7.06
> > +pkgrel=2
> > +pkgdesc="Open client for Cisco AnyConnect VPN"
> > +url="http://www.infradead.org/openconnect/"
> > +arch="all"
> > +license="LGPL2.1"
> > +depends="libxml2 gnutls libproxy vpnc krb5 lz4 openssl"
> > 
> 
> 
> abuild will automatically pull in the needed runtime dependencies for
> shared libraries so you will most likely not need the libxml2, gnutls
> etc dependencies listed there.
> 
> > +depends_dev="libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev lz4-dev openssl-dev gettext"
> > +makedepends="intltool python"
> > 
> 
> 
> depends_dev will only be added as dependency for a -dev subpackage.
> Since there are no subpackages in this case, the depends_dev is
> meaningless.
> 
> I believe you need to move all the packages in depends_dev to makedepends.
> 
> I am also not sure if gettext dep is needed?
> 
> Care to send a v2 patch?
> 
> http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch
> 
> -nc 
Natanael Copa
Details
Message ID
<20151015092344.2d8065f6@ncopa-desktop.alpinelinux.org>
In-Reply-To
<68E15DF47C014DD1BF1681D8AE7BFDB4@gmail.com> (view parent)
Sender timestamp
1444893824
DKIM signature
missing
Download raw message
On Wed, 7 Oct 2015 20:43:11 +0800
Myautsai PAN <myautsai@gmail.com> wrote:

> Dear Natanael, 
> 
> Sorry about my delay.

same :)
 
> http://patchwork.alpinelinux.org/patch/562/ is the old patch. I
> updated the patch by instruction in
> http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch .
> But somehow [a new patch](http://patchwork.alpinelinux.org/patch/684/
> ) is created. I'm not sure whether I'm doing the right thing. If not
> so, please close #562 and just use #684.

You are doing right. Thanks.

> Personally I strongly suggest immigrating from patchwork to GitHub
> and use the PR-mode. 

I hope you understand that we cannot change the way we work every time
there comes a new contributor which happens to prefer other tools and
workflows.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] [PATCH v2] testing/openconnect: new aport

Natanael Copa
Details
Message ID
<20151015093252.7f5c019e@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1444221059-5468-1-git-send-email-myautsai@gmail.com> (view parent)
Sender timestamp
1444894372
DKIM signature
missing
Download raw message
On Wed,  7 Oct 2015 20:30:59 +0800
"PAN, Myautsai" <myautsai@gmail.com> wrote:

> From: mckelvin <mckelvin@users.noreply.github.com>
> 
> http://www.infradead.org/openconnect/
> Open client for Cisco AnyConnect VPN

Sorry for not reading patch more careful last time.
> ---
>  testing/openconnect/APKBUILD | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 testing/openconnect/APKBUILD
> 
> diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
> new file mode 100644
> index 0000000..f8c6bd0
> --- /dev/null
> +++ b/testing/openconnect/APKBUILD
> @@ -0,0 +1,34 @@
> +# Contributor: Myautsai PAN <myautsai@gmail.com>
> +# Maintainer: Myautsai PAN <myautsai@gmail.com>
> +
> +pkgname=openconnect
> +pkgver=7.06
> +pkgrel=2
> +pkgdesc="Open client for Cisco AnyConnect VPN"
> +url="http://www.infradead.org/openconnect/"
> +arch="all"
> +license="LGPL2.1"
> +depends="libxml2 libproxy vpnc krb5 lz4 openssl"

depends looks wrong. abuild will automatically detect the shared libs
dependencies. It will not be able to detect if a script needs a
program, so if openconnect needs /usr/bin/openssl and similar then the
package that contains the program will need to be in depends. Otherwise
depends should be empty.

After building the package you can check with 'apk info -R openconnect'
to see what it pulled in as dependencies. (note that shared libs will
also automatically have a "so:<SONAME>" provides. that way we can
rename packages or move libs to different sub packages without needing
to depends everywhere)

Can you please send a v3 of the patch?

thanks!

> +makedepends="autoconf automake intltool python openssl-dev libxml2-dev lz4-dev libproxy-dev"
> +source="ftp://ftp.infradead.org/pub/$pkgname/$pkgname-$pkgver.tar.gz"
> +
> +_builddir=$srcdir/$pkgname-$pkgver
> +build() {
> +    cd $_builddir
> +    ./configure --prefix=/usr \
> +        --sbindir=/usr/bin \
> +        --disable-static \
> +        --without-gnutls \
> +        --disable-nls
> +    sed -i -r 's/\/\* #undef ICONV_CONST \*\//#define ICONV_CONST/' config.h
> +    make
> +}
> +
> +package() {
> +    cd $_builddir
> +    make DESTDIR="$pkgdir" install
> +}
> +
> +md5sums="80f397911e1fed43d897d99be3d5f1a1  openconnect-7.06.tar.gz"
> +sha256sums="facf695368dc4537a6a30e2147be90b1d77ee3cb2d269eaef070b6d9ddab70f2  openconnect-7.06.tar.gz"
> +sha512sums="d1af9efe4ac1f6671dc6b92db0df981e8cae3f2f50b8b4c35a112b42a76517b7c8ea9fd5da93352445dd61da3012bf34fdbcc3add9d8727cbaad7d311e516108  openconnect-7.06.tar.gz"



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

[alpine-aports] [PATCH v3] testing/openconnect: new aport

PAN, Myautsai
Details
Message ID
<1445086264-79126-1-git-send-email-myautsai@gmail.com>
In-Reply-To
<1442078171-36189-1-git-send-email-myautsai@gmail.com> (view parent)
Sender timestamp
1445086264
DKIM signature
missing
Download raw message
Patch: +34 -0
From: mckelvin <mckelvin@users.noreply.github.com>

http://www.infradead.org/openconnect/
Open client for Cisco AnyConnect VPN
---
 testing/openconnect/APKBUILD | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 testing/openconnect/APKBUILD

diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
new file mode 100644
index 0000000..75c965d
--- /dev/null
+++ b/testing/openconnect/APKBUILD
@@ -0,0 +1,34 @@
+# Contributor: Myautsai PAN <myautsai@gmail.com>
+# Maintainer: Myautsai PAN <myautsai@gmail.com>
+
+pkgname=openconnect
+pkgver=7.06
+pkgrel=2
+pkgdesc="Open client for Cisco AnyConnect VPN"
+url="http://www.infradead.org/openconnect/"
+arch="all"
+license="LGPL2.1"
+depends="vpnc"
+makedepends="autoconf automake intltool python openssl-dev libxml2-dev lz4-dev libproxy-dev"
+source="ftp://ftp.infradead.org/pub/$pkgname/$pkgname-$pkgver.tar.gz"
+
+_builddir=$srcdir/$pkgname-$pkgver
+build() {
+    cd $_builddir
+    ./configure --prefix=/usr \
+        --sbindir=/usr/bin \
+        --disable-static \
+        --without-gnutls \
+        --disable-nls
+    sed -i -r 's/\/\* #undef ICONV_CONST \*\//#define ICONV_CONST/' config.h
+    make
+}
+
+package() {
+    cd $_builddir
+    make DESTDIR="$pkgdir" install
+}
+
+md5sums="80f397911e1fed43d897d99be3d5f1a1  openconnect-7.06.tar.gz"
+sha256sums="facf695368dc4537a6a30e2147be90b1d77ee3cb2d269eaef070b6d9ddab70f2  openconnect-7.06.tar.gz"
+sha512sums="d1af9efe4ac1f6671dc6b92db0df981e8cae3f2f50b8b4c35a112b42a76517b7c8ea9fd5da93352445dd61da3012bf34fdbcc3add9d8727cbaad7d311e516108  openconnect-7.06.tar.gz"
-- 
2.4.6



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---