~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[alpine-aports] [PATCH] main/nano: Upgrade to 2.7.4. Change maintainer.

Przemyslaw Pawelczyk
Details
Message ID
<20170114005016.27359-1-przemoc@zoho.com>
Sender timestamp
1484355016
DKIM signature
missing
Download raw message
Patch: +6 -7
Old alleged maintainer (Michael Zhou) made himself maintainer with
commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched
nano ever again.  He has almost no trace of any activity in aports repo
since 2011 (1 commit in 2016).

Natanael Copa is the most active contributor, so hopefully he's not
against becoming maintainer of another package.
---
 main/nano/APKBUILD | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD
index 850af16fb8a7..b5b8362e69e3 100644
--- a/main/nano/APKBUILD
+++ b/main/nano/APKBUILD
@@ -1,13 +1,12 @@
 # Contributor: Michael Mason <ms13sp@gmail.com>
-# Maintainer: Michael Zhou <zhoumichaely@gmail.com>
+# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=nano
-pkgver=2.7.3
+pkgver=2.7.4
 pkgrel=0
 pkgdesc="Text Editor. GNU nano is designed to be a free replacement for the Pico text editor."
 url="http://www.nano-editor.org/"
 arch="all"
 license="GPL"
-depends=
 makedepends="ncurses-dev file-dev"
 subpackages="$pkgname-doc $pkgname-syntax::noarch"
 source="http://www.nano-editor.org/dist/v${pkgver%.*}/$pkgname-$pkgver.tar.gz
@@ -31,7 +30,7 @@ build() {
 package() {
 	cd "$builddir"
 	make DESTDIR="$pkgdir" install
-	install -Dm644 doc/nanorc.sample \
+	install -Dm644 doc/sample.nanorc \
 		"$pkgdir"/etc/nanorc || return 1
 
 	# Proper syntax highlighting for APKBUILDs
@@ -48,6 +47,6 @@ syntax() {
 		"$subpkgdir"/usr/share/$pkgname/ || return 1
 }
 
-md5sums="007ba6321212d3ec38f46236465b6ea8  nano-2.7.3.tar.gz"
-sha256sums="3574d4594d051f3b572c47d63bfc3763fb1148c50b811ba7a016bacd94887a88  nano-2.7.3.tar.gz"
-sha512sums="cd159cf193f05b37f770ac79e532fe96be158688d241ab7090861016fe0da9dde2ab504d0703b8feea8043e1deded3f10f0ab4dd5cceba99fe4a1dfcf5062b0b  nano-2.7.3.tar.gz"
+md5sums="e3a6b2740eb31f8a06d585f44d883895  nano-2.7.4.tar.gz"
+sha256sums="23ffc2de52d687739fed6dc2fc94df36aa7da7bb52c8740c523fdd7336fdbc8c  nano-2.7.4.tar.gz"
+sha512sums="029fa2ef72a8762f376f1cfc3f4cdcabfcb226868e5c68c5980162333099f23e74e77da2dda66b4e70e2840b9a0e472db821248327b417b3cf5132093eeb80ee  nano-2.7.4.tar.gz"
-- 
2.8.3




---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

[alpine-aports] [PATCH v2] main/nano: Ditch empty vars in APKBUILD. Change maintainer.

Przemyslaw Pawelczyk
Details
Message ID
<20170114194146.26046-1-przemoc@zoho.com>
In-Reply-To
<20170114005016.27359-1-przemoc@zoho.com> (view parent)
Sender timestamp
1484422906
DKIM signature
missing
Download raw message
Patch: +2 -3
Old alleged maintainer (Michael Zhou) made himself maintainer with
commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched
nano ever again.  He has almost no trace of any activity in aports repo
since 2011 (1 commit in 2016).

Natanael Copa is the most active contributor, so hopefully he's not
against becoming maintainer of another package.
---

Łukasz Jendrysik was not aware of my nano upgrade in patchwork,
so he did PR in github and Jakub Jirutka applied it quickly then.
Here is the remaining part of my original patch.


 main/nano/APKBUILD | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD
index 3bbd36ac9945..ccdfc2f661d9 100644
--- a/main/nano/APKBUILD
+++ b/main/nano/APKBUILD
@@ -1,13 +1,12 @@
 # Contributor: Michael Mason <ms13sp@gmail.com>
-# Maintainer: Michael Zhou <zhoumichaely@gmail.com>
+# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=nano
 pkgver=2.7.4
-pkgrel=0
+pkgrel=1
 pkgdesc="Text Editor. GNU nano is designed to be a free replacement for the Pico text editor."
 url="http://www.nano-editor.org/"
 arch="all"
 license="GPL"
-depends=
 makedepends="ncurses-dev file-dev"
 subpackages="$pkgname-doc $pkgname-syntax::noarch"
 source="http://www.nano-editor.org/dist/v${pkgver%.*}/$pkgname-$pkgver.tar.gz"
-- 
2.8.3




---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in APKBUILD. Change maintainer.

Leonardo Arena
Details
Message ID
<1484744349.8117.5.camel@gmail.com>
In-Reply-To
<20170114194146.26046-1-przemoc@zoho.com> (view parent)
Sender timestamp
1484744349
DKIM signature
missing
Download raw message
Hi,

On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote:
> Old alleged maintainer (Michael Zhou) made himself maintainer with
> commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched
> nano ever again.  He has almost no trace of any activity in aports
> repo
> since 2011 (1 commit in 2016).
> 
> Natanael Copa is the most active contributor, so hopefully he's not
> against becoming maintainer of another package.
> ---
> 
> Łukasz Jendrysik was not aware of my nano upgrade in patchwork,
> so he did PR in github and Jakub Jirutka applied it quickly then.
> Here is the remaining part of my original patch.
> 
> 
>  main/nano/APKBUILD | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD
> index 3bbd36ac9945..ccdfc2f661d9 100644
> --- a/main/nano/APKBUILD
> +++ b/main/nano/APKBUILD
> @@ -1,13 +1,12 @@
>  # Contributor: Michael Mason <ms13sp@gmail.com>
> -# Maintainer: Michael Zhou <zhoumichaely@gmail.com>
> +# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=nano
>  pkgver=2.7.4
> -pkgrel=0
> +pkgrel=1

I don't think we need to really rebuild the package for this. Hence
pkgrel can be left untouched.

Thanks!

-|_eo

Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in APKBUILD. Change maintainer.

Przemysław Pawełczyk
Details
Message ID
<159b359c343.df2494d47904.5259965377121748158@zoho.com>
In-Reply-To
<1484744349.8117.5.camel@gmail.com> (view parent)
Sender timestamp
1484772721
DKIM signature
missing
Download raw message
Hi!

 ---- On Wed, 18 Jan 2017 13:59:09 +0100 Leonardo Arena <rnalrd@gmail.com> wrote ---- 
 > On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote: 
 > > Old alleged maintainer (Michael Zhou) made himself maintainer with 
 > > commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched 
 > > nano ever again.  He has almost no trace of any activity in aports 
 > > repo 
 > > since 2011 (1 commit in 2016). 
 > >  
 > > Natanael Copa is the most active contributor, so hopefully he's not 
 > > against becoming maintainer of another package. 
 > > --- 
 > >  
 > > Łukasz Jendrysik was not aware of my nano upgrade in patchwork, 
 > > so he did PR in github and Jakub Jirutka applied it quickly then. 
 > > Here is the remaining part of my original patch. 
 > >  
 > >  
 > >  main/nano/APKBUILD | 5 ++--- 
 > >  1 file changed, 2 insertions(+), 3 deletions(-) 
 > >  
 > > diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD 
 > > index 3bbd36ac9945..ccdfc2f661d9 100644 
 > > --- a/main/nano/APKBUILD 
 > > +++ b/main/nano/APKBUILD 
 > > @@ -1,13 +1,12 @@ 
 > >  # Contributor: Michael Mason <ms13sp@gmail.com> 
 > > -# Maintainer: Michael Zhou <zhoumichaely@gmail.com> 
 > > +# Maintainer: Natanael Copa <ncopa@alpinelinux.org> 
 > >  pkgname=nano 
 > >  pkgver=2.7.4 
 > > -pkgrel=0 
 > > +pkgrel=1 
 >  
 > I don't think we need to really rebuild the package for this. Hence 
 > pkgrel can be left untouched. 

AFAIK pkgs.alpinelinux.org updates its info when the package is built, therefore I think it's good to bump pkgrel. Changing maintainer should be reflected in AL services.
 
In the old days (not that long ago) ncopa requested that each change in APKBUILD should lead to pkgrel bump, which is a safe and sane approach, even if a bit wasteful.

Some time ago APKBUILD improvements started to be applied without pkgrel bump, which can be acceptable in case of trivial changes (like my removal of empty vars here and there), but shouldn't be acceptable in general (like _builddir -> builddir rename and prepare() removal, because different code path in abuild is performed then).

Changing maintainer, while being trivial in diff, is important change, thus I strongly suggest to not drop pkgrel bump from this patch.

 > Thanks! 
 >  
 > -|_eo 
 
Regards,
Przemek



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in APKBUILD. Change maintainer.

Leonardo Arena
Details
Message ID
<1484909802.8117.28.camel@gmail.com>
In-Reply-To
<159b359c343.df2494d47904.5259965377121748158@zoho.com> (view parent)
Sender timestamp
1484909802
DKIM signature
missing
Download raw message
On mer, 2017-01-18 at 21:52 +0100, Przemysław Pawełczyk wrote:
> Hi!
> 
>  ---- On Wed, 18 Jan 2017 13:59:09 +0100 Leonardo Arena <rnalrd@gmail
> .com> wrote ---- 
>  > On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote: 
>  > > Old alleged maintainer (Michael Zhou) made himself maintainer
> with 
>  > > commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never
> touched 
>  > > nano ever again.  He has almost no trace of any activity in
> aports 
>  > > repo 
>  > > since 2011 (1 commit in 2016). 
>  > >  
>  > > Natanael Copa is the most active contributor, so hopefully he's
> not 
>  > > against becoming maintainer of another package. 
>  > > --- 
>  > >  
>  > > Łukasz Jendrysik was not aware of my nano upgrade in patchwork, 
>  > > so he did PR in github and Jakub Jirutka applied it quickly
> then. 
>  > > Here is the remaining part of my original patch. 
>  > >  
>  > >  
>  > >  main/nano/APKBUILD | 5 ++--- 
>  > >  1 file changed, 2 insertions(+), 3 deletions(-) 
>  > >  
>  > > diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD 
>  > > index 3bbd36ac9945..ccdfc2f661d9 100644 
>  > > --- a/main/nano/APKBUILD 
>  > > +++ b/main/nano/APKBUILD 
>  > > @@ -1,13 +1,12 @@ 
>  > >  # Contributor: Michael Mason <ms13sp@gmail.com
>  > > -# Maintainer: Michael Zhou <zhoumichaely@gmail.com
>  > > +# Maintainer: Natanael Copa <ncopa@alpinelinux.org
>  > >  pkgname=nano 
>  > >  pkgver=2.7.4 
>  > > -pkgrel=0 
>  > > +pkgrel=1 
>  >  
>  > I don't think we need to really rebuild the package for this.
> Hence 
>  > pkgrel can be left untouched. 
> 
> AFAIK pkgs.alpinelinux.org updates its info when the package is
> built, therefore I think it's good to bump pkgrel. Changing
> maintainer should be reflected in AL services.
>  

It makes sense.

> In the old days (not that long ago) ncopa requested that each change
> in APKBUILD should lead to pkgrel bump, which is a safe and sane
> approach, even if a bit wasteful.
> 
> Some time ago APKBUILD improvements started to be applied without
> pkgrel bump, which can be acceptable in case of trivial changes (like
> my removal of empty vars here and there), but shouldn't be acceptable
> in general (like _builddir -> builddir rename and prepare() removal,
> because different code path in abuild is performed then).
> 

Agree

> Changing maintainer, while being trivial in diff, is important
> change, thus I strongly suggest to not drop pkgrel bump from this
> patch.
> 

Accepted as is. :-)

Thanks!

-|_eo