Patches for aports can be sent to this list

1

[alpine-aports] [PATCH] testing/cava: new aport

Sascha Paunovic
Details
Message ID
<20180701144515.6785-1-azarus@posteo.net>
Sender timestamp
1530456315
DKIM signature
missing
Download raw message
Patch: +38 -0
---
 testing/cava/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 testing/cava/APKBUILD

diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD
new file mode 100644
index 0000000000..b2dfe566e7
--- /dev/null
+++ b/testing/cava/APKBUILD
@@ -0,0 +1,38 @@
+# Contributor: Sascha Paunovic <azarus@posteo.net>
+# Maintainer: Sascha Paunovic <azarus@posteo.net>
+#TODO: pulseaudio & sndio subpackage
+pkgname=cava
+pkgver=0.6.1
+pkgrel=0
+pkgdesc="console based audio visualizer for ALSA & more"
+url="https://github.com/karlstav/cava"
+arch="all"
+license="MIT"
+makedepends="fftw-dev ncurses-dev alsa-lib-dev libtool"
+source="$pkgname-$pkgver.tar.gz::https://github.com/karlstav/$pkgname/archive/$pkgver.tar.gz"
+builddir="$srcdir/$pkgname-$pkgver"
+
+build() {
+	cd "$builddir"
+	autoreconf -if
+	./configure \
+		--build=$CBUILD \
+		--host=$CHOST \
+		--prefix=/usr \
+		--sysconfdir=/etc \
+		--mandir=/usr/share/man \
+		--localstatedir=/var
+	make
+}
+
+check() {
+	cd "$builddir"
+	make check # currently doesn't do much, but better than nothing
+}
+
+package() {
+	cd "$builddir"
+	make DESTDIR="$pkgdir" install
+}
+
+sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f3423e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb  cava-0.6.1.tar.gz"
-- 
2.18.0



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Leonardo Arena
Details
Message ID
<CAGG_d8Bzy9BTHi=PR6y120UpbOoyRxDx78z+eTpF10Zz=iRN8g@mail.gmail.com>
In-Reply-To
<20180701144515.6785-1-azarus@posteo.net> (view parent)
Sender timestamp
1531316432
DKIM signature
missing
Download raw message
Hi,

please see some comments below:

On Sun, Jul 1, 2018 at 4:45 PM, Sascha Paunovic <azarus@posteo.net> wrote:

> ---
>  testing/cava/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 testing/cava/APKBUILD
>
> diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD
> new file mode 100644
> index 0000000000..b2dfe566e7
> --- /dev/null
> +++ b/testing/cava/APKBUILD
> @@ -0,0 +1,38 @@
> +# Contributor: Sascha Paunovic <azarus@posteo.net>
> +# Maintainer: Sascha Paunovic <azarus@posteo.net>
> +#TODO: pulseaudio & sndio subpackage
> +pkgname=cava
> +pkgver=0.6.1
> +pkgrel=0
> +pkgdesc="console based audio visualizer for ALSA & more"
> +url="https://github.com/karlstav/cava"
> +arch="all"
> +license="MIT"
> +makedepends="fftw-dev ncurses-dev alsa-lib-dev libtool"
>


Automake and autoconf are missing.



> +source="$pkgname-$pkgver.tar.gz::https://github.com/
> karlstav/$pkgname/archive/$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
> +
> +build() {
> +       cd "$builddir"
> +       autoreconf -if
>


autoreconf should be moved into "prepare()" which should run also
"default_prepare" first.



> +       ./configure \
> +               --build=$CBUILD \
> +               --host=$CHOST \
> +               --prefix=/usr \
> +               --sysconfdir=/etc \
> +               --mandir=/usr/share/man \
> +               --localstatedir=/var
> +       make
> +}
> +
> +check() {
> +       cd "$builddir"
> +       make check # currently doesn't do much, but better than nothing
> +}
> +
> +package() {
> +       cd "$builddir"
> +       make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f342
> 3e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb
> cava-0.6.1.tar.gz"
>
>

Everything else looks good, thanks!

/eo