Patches for aports can be sent to this list

2 2

[alpine-aports] [PATCH] testing/telegram-desktop: drop maintainership

Alex Raschi
Details
Message ID
<20190512120751.27955-1-raschi.alex@gmail.com>
Sender timestamp
1557662871
DKIM signature
missing
Download raw message
Patch: +1 -1
the aport has been rewritten and now uses an unofficial third party build
system that i don't want to maintain
---
 testing/telegram-desktop/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/telegram-desktop/APKBUILD b/testing/telegram-desktop/APKBUILD
index d951cff246..77770120c5 100644
--- a/testing/telegram-desktop/APKBUILD
+++ b/testing/telegram-desktop/APKBUILD
@@ -1,4 +1,4 @@
-# Maintainer: Alex Raschi <raschi.alex@gmail.com>
+# Maintainer:
 # Contributor: Leo <thinkabit.ukim@gmail.com>
 pkgname=telegram-desktop
 pkgver=1.6.7
-- 
2.21.0



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Details
Message ID
<20190512164734.GB23109@alpha>
In-Reply-To
<20190512120751.27955-1-raschi.alex@gmail.com> (view parent)
Sender timestamp
1557679654
DKIM signature
missing
Download raw message
Sad to here this.

It was necessary because the build was failing and only a limited amount
of people have access to create snapshots and upload them to dev.

We prefer being able to build packages without having to create archives
ourselfs. It just happened that this PR was already available so that
was the quickest way to get things building again.

If you know a way to use the official build system but not having to
rely on creating snapshots, we're happy to use that.

Kind regards, Kevin.

On Sun, May 12, 2019 at 02:07:51PM +0200, Alex Raschi wrote:
> the aport has been rewritten and now uses an unofficial third party build
> system that i don't want to maintain
> ---
>  testing/telegram-desktop/APKBUILD | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testing/telegram-desktop/APKBUILD b/testing/telegram-desktop/APKBUILD
> index d951cff246..77770120c5 100644
> --- a/testing/telegram-desktop/APKBUILD
> +++ b/testing/telegram-desktop/APKBUILD
> @@ -1,4 +1,4 @@
> -# Maintainer: Alex Raschi <raschi.alex@gmail.com>
> +# Maintainer:
>  # Contributor: Leo <thinkabit.ukim@gmail.com>
>  pkgname=telegram-desktop
>  pkgver=1.6.7
> -- 
> 2.21.0
> 
> 
> 
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
> 


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Alex Raschi
Details
Message ID
<CAOcb4q7gnDGKPzs_5Bp6FZaBDyLyGrmhY7FX+8fo=7eyVrdrfw@mail.gmail.com>
In-Reply-To
<20190512164734.GB23109@alpha> (view parent)
Sender timestamp
1557688805
DKIM signature
missing
Download raw message
Hi Kevin,

I didn't know about the snapshots situation and i understand the issues of
uploading archives.

Yes there is an another way to avoid creating a snapshot but as you can see
in
the committed change, it requires keeping track of additional dependencies
manually which involves of checking git hashes every time.

That's why the aport used snapshots and i opted for this solution when i
wrote
it, with git submodules is a lot easier.

Rewriting aport without any sort of advise to the maintainer should be
avoided
in my opinion, i found it rewritten without knowing anything since i don't
use
github and the patch comes from there.

The new build seems to require to update the source file lists with every
new
update too, and this doesn't seem to me a good change. Let just clone gyp
with
another archive then, rather than using something not supported upstream if
possible.

Anyway i am a little busy lately so if there is someone that would maintain
better the package then ok, i don't mind that. I can't hide the fact that
the
previous commit pissed me off a little...

Cheers, Alex.

On Sun, May 12, 2019 at 4:47 PM Kevin Daudt <kdaudt@alpinelinux.org> wrote:

> Sad to here this.
>
> It was necessary because the build was failing and only a limited amount
> of people have access to create snapshots and upload them to dev.
>
> We prefer being able to build packages without having to create archives
> ourselfs. It just happened that this PR was already available so that
> was the quickest way to get things building again.
>
> If you know a way to use the official build system but not having to
> rely on creating snapshots, we're happy to use that.
>
> Kind regards, Kevin.
>
> On Sun, May 12, 2019 at 02:07:51PM +0200, Alex Raschi wrote:
> > the aport has been rewritten and now uses an unofficial third party build
> > system that i don't want to maintain
> > ---
> >  testing/telegram-desktop/APKBUILD | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/testing/telegram-desktop/APKBUILD
> b/testing/telegram-desktop/APKBUILD
> > index d951cff246..77770120c5 100644
> > --- a/testing/telegram-desktop/APKBUILD
> > +++ b/testing/telegram-desktop/APKBUILD
> > @@ -1,4 +1,4 @@
> > -# Maintainer: Alex Raschi <raschi.alex@gmail.com>
> > +# Maintainer:
> >  # Contributor: Leo <thinkabit.ukim@gmail.com>
> >  pkgname=telegram-desktop
> >  pkgver=1.6.7
> > --
> > 2.21.0
> >
> >
> >
> > ---
> > Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> > Help:         alpine-aports+help@lists.alpinelinux.org
> > ---
> >
>