> +makedepends="python3-dev py-setuptools"
Since this is a py3- package the py-setuptools should be py3-setuptools
Since this py3- package is noarch the python3-dev is not required, it can be
removed entirely
> + cd "$builddir"
Can be removed
> + cd "$builddir"
Can be removed
The commit title is wrong, please fix
<repo>/<package>: upgrade to <version>
> +depends="py3-cairo py3-gobject3 py3-asn1 py3-nbxmpp py3-openssl py3-precis-i18n py3-keyring py3-cssutils gtk+3.0"
Please cut this line at 80 columns
> +makedepends="python3-dev py-setuptools"
py3-setuptools instead of py-setuptools and python3-dev can be removed
> + cd "$builddir"
Can be removed
> + cd "$builddir"
Can be removed
Re: [PATCH 2/8] testing/py3-precis-i18n: New aport
> +makedepends="python3-dev py-setuptools"
python3-dev can be removed and use py3-setuptools instead of py-setuptools
> + cd "$builddir"
can be removed
> + cd "$builddir"
can be removed
> +arch="noarch"> +license="MIT"> +makedepends="python3-dev py-setuptools yaml-dev py3-pytest py3-pytest-cov"
Use py3-setuptools, python3-dev and yaml-dev can be replaced by py3-yaml and
be moved to checkdepends together with py3-pytest{,-cov}
> + cd "$builddir"
Can be removed
> + cd "$builddir"
Can be removed
Hi,
thanks for the fast review. The attached patch is fixed accordingly.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:19:43 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> Commit title tis wrong, should be:> > <repository>/<package>: upgrade to <version>
Re: [PATCH 2/8] testing/py3-precis-i18n: New aport
Hi,
the attached patch is fixed according to your comments. Thanks for the quick
review.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:14:02 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> > +makedepends="python3-dev py-setuptools" > > python3-dev can be removed and use py3-setuptools instead of py-setuptools> > > + cd "$builddir" > > can be removed> > > + cd "$builddir" > > can be removed
Hi,
the attached patch is fixed according to your comments. Thanks for the quick
review.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:18:20 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> > +arch="noarch"> > +license="MIT"> > +makedepends="python3-dev py-setuptools yaml-dev py3-pytest py3-pytest-cov" > > Use py3-setuptools, python3-dev and yaml-dev can be replaced by py3-yaml and> be moved to checkdepends together with py3-pytest{,-cov}> > > + cd "$builddir" > > Can be removed> > > + cd "$builddir" > > Can be removed
Hi,
the attached patch is fixed according to your comments. Thanks for the quick
review.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:08:07 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> > +makedepends="python3-dev py-setuptools" > > Since this is a py3- package the py-setuptools should be py3-setuptools> > Since this py3- package is noarch the python3-dev is not required, it can be> removed entirely> > > + cd "$builddir" > > Can be removed> > > + cd "$builddir" > > Can be removed
Hi,
the attached patch is fixed according to your comments. Thanks for the quick
review.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:12:50 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> > +makedepends="python3-dev py-setuptools" > > py3-setuptools instead of py-setuptools and python3-dev can be removed> > > + cd "$builddir" > > Can be removed> > > + cd "$builddir" > > Can be removed
Hi,
the attached patch is fixed according to your comments. Thanks for the quick
review. Also, I couldn't resist from making the indent consistently.
Kind regards,
Marian
On Sat, 13 Jul 2019 12:11:52 -0300
Leo <thinkabit.ukim@gmail.com> wrote:
> The commit title is wrong, please fix> > <repo>/<package>: upgrade to <version>> > > +depends="py3-cairo py3-gobject3 py3-asn1 py3-nbxmpp py3-openssl py3-precis-i18n py3-keyring py3-cssutils gtk+3.0" > > Please cut this line at 80 columns