~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] community/fzf: build using go instead of make

Details
Message ID
<20191002220344.2814-1-rjwhite2453@gmail.com>
DKIM signature
missing
Download raw message
Patch: +10 -6
From: Robert White <rjwhite2453@gmail.com>

This way all architectures are supported.
---
 community/fzf/APKBUILD | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/community/fzf/APKBUILD b/community/fzf/APKBUILD
index 92dd89acd1..24c9ce8bd4 100644
--- a/community/fzf/APKBUILD
+++ b/community/fzf/APKBUILD
@@ -1,3 +1,4 @@
# Contributor: Robert White <rjwhite2453@gmail.com>
# Contributor: Kevin Daudt <kdaudt@alpinelinux.org>
# Maintainer: Kevin Daudt <kdaudt@alpinelinux.org>
pkgname=fzf
@@ -5,7 +6,7 @@ pkgver=0.18.0
pkgrel=4
pkgdesc="A command-line fuzzy finder"
url="https://github.com/junegunn/fzf"
arch="all !s390x !aarch64 !armhf !armv7"
arch="all"
license="MIT"
makedepends="go glide bash tmux"
subpackages="
@@ -36,18 +37,21 @@ prepare() {

build() {
	cd "$builddir"
	make
	go build
}

check() {
	cd "$builddir"
	make test
 	cd "$builddir"
	SHELL=/bin/sh GOOS= go test -v \
		github.com/junegunn/fzf/src \
		github.com/junegunn/fzf/src/algo \
		github.com/junegunn/fzf/src/tui \
		github.com/junegunn/fzf/src/util
}

package() {
	cd "$builddir"
	make install # Just copies the target binary to $buildir/bin
	install -Dm0755 bin/fzf "$pkgdir"/usr/bin/fzf
	install -Dm0755 fzf "$pkgdir"/usr/bin/fzf

	install -D man/man1/fzf.1 "$pkgdir"/usr/share/man/man1/fzf.1
	install -D man/man1/fzf-tmux.1 "$pkgdir"/usr/share/man/man1/fzf-tmux.1
-- 
2.22.0
Details
Message ID
<20191031081738.GB356904@alpha>
In-Reply-To
<20191002220344.2814-1-rjwhite2453@gmail.com> (view parent)
DKIM signature
missing
Download raw message
On Thu, Oct 03, 2019 at 08:03:44AM +1000, rjwhite2453@gmail.com wrote:
> From: Robert White <rjwhite2453@gmail.com>
> 
> This way all architectures are supported.
> ---
>  community/fzf/APKBUILD | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 

Thanks! I've pushed this with a small addition to fix cleaning up the
modcache (which otherwise would result in permission denied errors):

+cleanup_srcdir() {
+       export GOPATH="$srcdir"
+       go clean -modcache
+       default_cleanup_srcdir
+}
Reply to thread Export thread (mbox)