~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] libedit: update to 20191025.3.1

Details
Message ID
<20191027142900.30512-1-sir@cmpwn.com>
DKIM signature
missing
Download raw message
Patch: +3 -8
Also normalizes the APKBUILD and adds -static
---
 main/libedit/APKBUILD | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/main/libedit/APKBUILD b/main/libedit/APKBUILD
index 147c3d48e3..7bc4ddeeb3 100644
--- a/main/libedit/APKBUILD
+++ b/main/libedit/APKBUILD
@@ -1,20 +1,15 @@
# Maintainer: Drew DeVault <sir@cmpwn.com>
pkgname=libedit
pkgver=20190324.3.1
pkgver=20191025.3.1
_ver=${pkgver/./-}
pkgrel=0
pkgdesc="BSD line editing library"
url="https://www.thrysoee.dk/editline"
arch="all"
license="BSD-3-Clause"
depends=""
depends_dev="ncurses-dev"
makedepends_build=""
makedepends_host="$depends_dev"
install=""
subpackages="$pkgname-dev $pkgname-doc"
subpackages="$pkgname-static $pkgname-dev $pkgname-doc"
source="https://www.thrysoee.dk/editline/libedit-$_ver.tar.gz"

builddir="$srcdir"/libedit-$_ver

build() {
@@ -41,4 +36,4 @@ package() {
	rm "$pkgdir"/usr/share/man/man3/history.3*
}

sha512sums="240098989e3c5c8c5e28a61036655ad5a57f1c484e1cce2eaf3da157ff238dfb9cd81c766f82efbefa0935b7b5c07328087788cbac007b11dfb558cfaccaedf3  libedit-20190324-3.1.tar.gz"
sha512sums="9f475249b984e02ece0af3a0efe353233fef644ecf37482e28597a3ce552ca5a07678939b2c4ecbe3d2b14761fa67f23d2e839a322b94c0feeeba9e403b2be00  libedit-20191025-3.1.tar.gz"
-- 
2.23.0
Details
Message ID
<3BHSXOIFDJLIP.3MYOHDGFH159F@8pit.net>
In-Reply-To
<20191027142900.30512-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
Hi,

Thanks for the patch, found one minor issue though.

Drew DeVault <sir@cmpwn.com> wrote:
> -makedepends_build=""
> -makedepends_host="$depends_dev"

If you remove this, makedepends will be empty, meaning: ncurses headers
will not be installed during compilation and the build will fail.
Unless, you have ncurses installed already, if you build with `abuild
rootbld` you might notice missing dependencies in the future.

Cheers,
Sören
Reply to thread Export thread (mbox)