~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH] testing/dino-git: new aport

Galen Abell <galen@galenabell.com>
Details
Message ID
<20191214181123.10757-1-galen@galenabell.com>
DKIM signature
missing
Download raw message
5 years ago
Patch: +50 -0 
https://dino.im
Modern Jabber/XMPP client
testing/
---
 testing/dino-git/APKBUILD | 50 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 testing/dino-git/APKBUILD

diff --git a/testing/dino-git/APKBUILD b/testing/dino-git/APKBUILD
new file mode 100644
index 0000000000..036ed20083
--- /dev/null
+++ b/testing/dino-git/APKBUILD
@@ -0,0 +1,50 @@
# Contributor: Galen Abell <galen@galenabell.com>
# Maintainer: Galen Abell <galen@galenabell.com>
pkgname="dino-git"
_pkgname="dino"
pkgver="20191213"
_pkgsha="21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e"
pkgrel=0
pkgdesc="Modern Jabber/XMPP client"
url="https://dino.im"
arch="all"
license="GPL-3.0-only"
makedepends="
	glib-dev
	glib-networking
	gtk+3.0-dev
	gpgme-dev
	libgee-dev
	libgcrypt-dev
	libsoup-dev
	sqlite-dev
	libqrencode-dev
	cmake
	vala
	ninja
"
subpackages="$pkgname-lang"
source="$_pkgname-$_pkgsha.tar.gz::https://github.com/dino/dino/archive/$_pkgsha.tar.gz"
builddir="$srcdir/$_pkgname-$_pkgsha"

build() {
	./configure \
		--build=$CBUILD \
		--host=$CHOST \
		--prefix=/usr \
		--sysconfdir=/etc \
		--mandir=/usr/share/man \
		--localstatedir=/var \
		--with-tests
	make
}

check() {
	build/xmpp-vala-test
	build/signal-protocol-vala-test
}

package() {
	make DESTDIR="$pkgdir" install
}
sha512sums="cc227c6bbcf62279aaf7a036ee9560b0dc7733c6774c934b16ac2b6546248ee6e48cdc06b62ea57b0e6cb1260c8f3155f18420796c325270316e1dbefb523da6  dino-21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e.tar.gz"
-- 
2.24.1
Kevin Daudt <kdaudt@alpinelinux.org>
Details
Message ID
<20191224055341.GA846450@alpha>
In-Reply-To
<20191214181123.10757-1-galen@galenabell.com> (view parent)
DKIM signature
missing
Download raw message
5 years ago 
Hello Galen,

Thanks for your contribution. Some feedback inline.

On Sat, Dec 14, 2019 at 01:11:23PM -0500, Galen Abell wrote:
> https://dino.im
> Modern Jabber/XMPP client
> testing/
> ---
>  testing/dino-git/APKBUILD | 50 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 testing/dino-git/APKBUILD
> 
> diff --git a/testing/dino-git/APKBUILD b/testing/dino-git/APKBUILD
> new file mode 100644
> index 0000000000..036ed20083
> --- /dev/null
> +++ b/testing/dino-git/APKBUILD
> @@ -0,0 +1,50 @@
> +# Contributor: Galen Abell <galen@galenabell.com>
> +# Maintainer: Galen Abell <galen@galenabell.com>
> +pkgname="dino-git"

In Alpine Linux, the preference is not to use the -git suffix. Just call
it dino.

> +_pkgname="dino"
> +pkgver="20191213"

This will prevent you from ever adopting upstream release versions if
they start using that (there is no epoch like construction in APKBUILD).

Instead, use this:

0_git20191213

This means this version will always be considered 'older' than any
release upstream will do.

> +_pkgsha="21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e"
> +pkgrel=0
> +pkgdesc="Modern Jabber/XMPP client"
> +url="https://dino.im"
> +arch="all"
> +license="GPL-3.0-only"
> +makedepends="
> +	glib-dev
> +	glib-networking
> +	gtk+3.0-dev
> +	gpgme-dev
> +	libgee-dev
> +	libgcrypt-dev
> +	libsoup-dev
> +	sqlite-dev
> +	libqrencode-dev
> +	cmake
> +	vala
> +	ninja
> +"
> +subpackages="$pkgname-lang"
> +source="$_pkgname-$_pkgsha.tar.gz::https://github.com/dino/dino/archive/$_pkgsha.tar.gz"
> +builddir="$srcdir/$_pkgname-$_pkgsha"
> +
> +build() {
> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--mandir=/usr/share/man \
> +		--localstatedir=/var \
> +		--with-tests
> +	make
> +}
> +
> +check() {
> +	build/xmpp-vala-test
> +	build/signal-protocol-vala-test
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +}
> +sha512sums="cc227c6bbcf62279aaf7a036ee9560b0dc7733c6774c934b16ac2b6546248ee6e48cdc06b62ea57b0e6cb1260c8f3155f18420796c325270316e1dbefb523da6  dino-21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e.tar.gz"
> -- 
> 2.24.1

[PATCH v2] testing/dino: new aport

Galen Abell <galen@galenabell.com>
Details
Message ID
<20191224174255.2105-1-galen@galenabell.com>
In-Reply-To
<20191224055341.GA846450@alpha> (view parent)
DKIM signature
missing
Download raw message
5 years ago
Patch: +49 -0 
https://dino.im
Modern Jabber/XMPP client
testing/
---
Thanks for the feedback! This patch changes the package name to Dino and
fixes the package version as requested.

 testing/dino/APKBUILD | 49 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 testing/dino/APKBUILD

diff --git a/testing/dino/APKBUILD b/testing/dino/APKBUILD
new file mode 100644
index 0000000000..f1860e8687
--- /dev/null
+++ b/testing/dino/APKBUILD
@@ -0,0 +1,49 @@
# Contributor: Galen Abell <galen@galenabell.com>
# Maintainer: Galen Abell <galen@galenabell.com>
pkgname="dino"
pkgver="0_git20191224"
_pkgsha="21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e"
pkgrel=0
pkgdesc="Modern Jabber/XMPP client"
url="https://dino.im"
arch="all"
license="GPL-3.0-only"
makedepends="
	glib-dev
	glib-networking
	gtk+3.0-dev
	gpgme-dev
	libgee-dev
	libgcrypt-dev
	libsoup-dev
	sqlite-dev
	libqrencode-dev
	cmake
	vala
	ninja
"
subpackages="$pkgname-lang"
source="$pkgname-$_pkgsha.tar.gz::https://github.com/dino/dino/archive/$_pkgsha.tar.gz"
builddir="$srcdir/$pkgname-$_pkgsha"

build() {
	./configure \
		--build=$CBUILD \
		--host=$CHOST \
		--prefix=/usr \
		--sysconfdir=/etc \
		--mandir=/usr/share/man \
		--localstatedir=/var \
		--with-tests
	make
}

check() {
	build/xmpp-vala-test
	build/signal-protocol-vala-test
}

package() {
	make DESTDIR="$pkgdir" install
}
sha512sums="cc227c6bbcf62279aaf7a036ee9560b0dc7733c6774c934b16ac2b6546248ee6e48cdc06b62ea57b0e6cb1260c8f3155f18420796c325270316e1dbefb523da6  dino-21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e.tar.gz"
-- 
2.24.1

Re: [PATCH v2] testing/dino: new aport

Kevin Daudt <kdaudt@alpinelinux.org>
Details
Message ID
<20191224183207.GB846450@alpha>
In-Reply-To
<20191224174255.2105-1-galen@galenabell.com> (view parent)
DKIM signature
missing
Download raw message
5 years ago 
On Tue, Dec 24, 2019 at 12:42:55PM -0500, Galen Abell wrote:
> https://dino.im
> Modern Jabber/XMPP client
> testing/
> ---
> Thanks for the feedback! This patch changes the package name to Dino and
> fixes the package version as requested.
> 
>  testing/dino/APKBUILD | 49 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 testing/dino/APKBUILD
> 
> diff --git a/testing/dino/APKBUILD b/testing/dino/APKBUILD
> new file mode 100644
> index 0000000000..f1860e8687
> --- /dev/null
> +++ b/testing/dino/APKBUILD
> @@ -0,0 +1,49 @@
> +# Contributor: Galen Abell <galen@galenabell.com>
> +# Maintainer: Galen Abell <galen@galenabell.com>
> +pkgname="dino"
> +pkgver="0_git20191224"
> +_pkgsha="21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e"
> +pkgrel=0
> +pkgdesc="Modern Jabber/XMPP client"
> +url="https://dino.im"
> +arch="all"
> +license="GPL-3.0-only"
> +makedepends="
> +	glib-dev
> +	glib-networking
> +	gtk+3.0-dev
> +	gpgme-dev
> +	libgee-dev
> +	libgcrypt-dev
> +	libsoup-dev
> +	sqlite-dev
> +	libqrencode-dev
> +	cmake
> +	vala
> +	ninja
> +"
> +subpackages="$pkgname-lang"
> +source="$pkgname-$_pkgsha.tar.gz::https://github.com/dino/dino/archive/$_pkgsha.tar.gz"
> +builddir="$srcdir/$pkgname-$_pkgsha"
> +
> +build() {
> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--mandir=/usr/share/man \
> +		--localstatedir=/var \
> +		--with-tests
> +	make
> +}
> +
> +check() {
> +	build/xmpp-vala-test
> +	build/signal-protocol-vala-test
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +}
> +sha512sums="cc227c6bbcf62279aaf7a036ee9560b0dc7733c6774c934b16ac2b6546248ee6e48cdc06b62ea57b0e6cb1260c8f3155f18420796c325270316e1dbefb523da6  dino-21c01dcdcb3ba7f7d5c6fcd18c5fd2117f050e5e.tar.gz"
> -- 
> 2.24.1

Hello Galen,

This has been applied. Note that I used the commit date for the version,
rather than the date of today, which makes slightly more sense.

Kind regards, Kevin
Reply to thread Export thread (mbox)