~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] community/libtorrent-rasterbar: use c++17

Details
Message ID
<20211125113301.305966-1-wolf@wolfsden.cz>
DKIM signature
missing
Download raw message
Patch: +2 -2
---
Segfaults when using the default c++ standard (14). There is a upstream
bug report stating that using 17 fixes the crash, and I can confirm
that is the case for me as well.

I will report to upstream later when I have a reproduction example.

This should go to 3.15 as well. Not sure how to send a patch against it.

 community/libtorrent-rasterbar/APKBUILD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/community/libtorrent-rasterbar/APKBUILD b/community/libtorrent-rasterbar/APKBUILD
index 380536eccf..211446f209 100644
--- a/community/libtorrent-rasterbar/APKBUILD
+++ b/community/libtorrent-rasterbar/APKBUILD
@@ -2,7 +2,7 @@
# Maintainer: August Klein <amatcoder@gmail.com>
pkgname=libtorrent-rasterbar
pkgver=1.2.14
pkgrel=2
pkgrel=3
pkgdesc="Feature complete C++ bittorrent implementation"
url="https://www.rasterbar.com/products/libtorrent"
arch="all !armv7 !aarch64 !x86" # on aarch64 and x86 failed to build
@@ -28,7 +28,7 @@ build() {
		--localstatedir=/var \
		--enable-python-binding \
		--with-boost-system=boost_python$_py3ver \
		--with-std=c++14
		--with-cxx-standard=17
	make
}

-- 
2.33.1
Details
Message ID
<20211125142418.54fce87a@ncopa-desktop.lan>
In-Reply-To
<20211125113301.305966-1-wolf@wolfsden.cz> (view parent)
DKIM signature
missing
Download raw message
On Thu, 25 Nov 2021 12:33:01 +0100
Wolf <wolf@wolfsden.cz> wrote:

> ---
> Segfaults when using the default c++ standard (14). There is a upstream
> bug report stating that using 17 fixes the crash, and I can confirm
> that is the case for me as well.

I think the commit message should include an answer to why the change
is needed.

> I will report to upstream later when I have a reproduction example.

I don't know if this might be related:
https://github.com/arvidn/libtorrent/issues/6451

> 
> This should go to 3.15 as well. Not sure how to send a patch against
> it.

Thanks!

> 
>  community/libtorrent-rasterbar/APKBUILD | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/community/libtorrent-rasterbar/APKBUILD
> b/community/libtorrent-rasterbar/APKBUILD index
> 380536eccf..211446f209 100644 ---
> a/community/libtorrent-rasterbar/APKBUILD +++
> b/community/libtorrent-rasterbar/APKBUILD @@ -2,7 +2,7 @@
>  # Maintainer: August Klein <amatcoder@gmail.com>
>  pkgname=libtorrent-rasterbar
>  pkgver=1.2.14
> -pkgrel=2
> +pkgrel=3
>  pkgdesc="Feature complete C++ bittorrent implementation"
>  url="https://www.rasterbar.com/products/libtorrent"
>  arch="all !armv7 !aarch64 !x86" # on aarch64 and x86 failed to build
> @@ -28,7 +28,7 @@ build() {
>  		--localstatedir=/var \
>  		--enable-python-binding \
>  		--with-boost-system=boost_python$_py3ver \
> -		--with-std=c++14
> +		--with-cxx-standard=17
>  	make
>  }
>  
Reply to thread Export thread (mbox)