https://facebook.github.io/PathPicker
TUI that lets you pick paths out of its stdin and run arbitrary commands on them

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
---
 testing/fpp/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 testing/fpp/APKBUILD

diff --git a/testing/fpp/APKBUILD b/testing/fpp/APKBUILD
new file mode 100644
index 0000000000..d1d5203461
--- /dev/null
+++ b/testing/fpp/APKBUILD
@@ -0,0 +1,38 @@
+# Contributor: Thiago Perrotta <tbperrotta@gmail.com>
+# Maintainer:
+pkgname=fpp
+pkgver=0.9.2
+pkgrel=0
+pkgdesc="TUI that lets you pick paths out of its stdin and run arbitrary commands on them"
+url="https://facebook.github.io/PathPicker"
+arch="noarch"
+license="MIT"
+depends="python3"
+subpackages="$pkgname-doc"
+options="!check" # broken tests
+source="$pkgname-$pkgver.tar.gz::https://github.com/facebook/PathPicker/archive/$pkgver.tar.gz"
+builddir="$srcdir/PathPicker-$pkgver"
+
+prepare() {
+	default_prepare
+
+	rm -r "src/__tests__"
+}
+
+package() {
+	# library
+	install -Dm755 "fpp" -t "$pkgdir/usr/share/fpp"
+	cp -a src "$pkgdir/usr/share/fpp"
+
+	# entrypoint
+	install -dm755 "$pkgdir/usr/bin"
+	ln -s "/usr/share/fpp/fpp" "$pkgdir/usr/bin"
+
+	# documentation
+	install -Dm644 LICENSE -t "$pkgdir/usr/share/licenses/$pkgname"
+	install -Dm644 "debian/usr/share/man/man1/fpp.1" -t "$pkgdir/usr/share/man/man1"
+}
+
+sha512sums="
+65b6b077f437bd642ebf94c55be901aabc73f7b9c89e4522c4f51970c4d63d744ad8fa29cac06816851f63bcb81d0480e61d405231c582e9aca0f4e650949a97  fpp-0.9.2.tar.gz
+"
-- 
2.34.1

https://facebook.github.io/PathPicker
TUI that lets you pick paths out of its stdin and run arbitrary commands on them

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
---
Added Maintainer.

 testing/fpp/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 testing/fpp/APKBUILD

diff --git a/testing/fpp/APKBUILD b/testing/fpp/APKBUILD
new file mode 100644
index 0000000000..699506b6f3
--- /dev/null
+++ b/testing/fpp/APKBUILD
@@ -0,0 +1,38 @@
+# Contributor: Thiago Perrotta <tbperrotta@gmail.com>
+# Maintainer: Thiago Perrotta <tbperrotta@gmail.com>
+pkgname=fpp
+pkgver=0.9.2
+pkgrel=0
+pkgdesc="TUI that lets you pick paths out of its stdin and run arbitrary commands on them"
+url="https://facebook.github.io/PathPicker"
+arch="noarch"
+license="MIT"
+depends="python3"
+subpackages="$pkgname-doc"
+options="!check" # broken tests
+source="$pkgname-$pkgver.tar.gz::https://github.com/facebook/PathPicker/archive/$pkgver.tar.gz"
+builddir="$srcdir/PathPicker-$pkgver"
+
+prepare() {
+	default_prepare
+
+	rm -r "src/__tests__"
+}
+
+package() {
+	# library
+	install -Dm755 "fpp" -t "$pkgdir/usr/share/fpp"
+	cp -a src "$pkgdir/usr/share/fpp"
+
+	# entrypoint
+	install -dm755 "$pkgdir/usr/bin"
+	ln -s "/usr/share/fpp/fpp" "$pkgdir/usr/bin"
+
+	# documentation
+	install -Dm644 LICENSE -t "$pkgdir/usr/share/licenses/$pkgname"
+	install -Dm644 "debian/usr/share/man/man1/fpp.1" -t "$pkgdir/usr/share/man/man1"
+}
+
+sha512sums="
+65b6b077f437bd642ebf94c55be901aabc73f7b9c89e4522c4f51970c4d63d744ad8fa29cac06816851f63bcb81d0480e61d405231c582e9aca0f4e650949a97  fpp-0.9.2.tar.gz
+"
-- 
2.34.1

https://facebook.github.io/PathPicker
TUI that lets you pick paths out of its stdin and run arbitrary commands on them

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
---
Differences to V1:

- add maintainer
- add bash dependency
- add simple check()

 testing/fpp/APKBUILD | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 testing/fpp/APKBUILD

diff --git a/testing/fpp/APKBUILD b/testing/fpp/APKBUILD
new file mode 100644
index 0000000000..0c312059d0
--- /dev/null
+++ b/testing/fpp/APKBUILD
@@ -0,0 +1,41 @@
+# Contributor: Thiago Perrotta <tbperrotta@gmail.com>
+# Maintainer: Thiago Perrotta <tbperrotta@gmail.com>
+pkgname=fpp
+pkgver=0.9.2
+pkgrel=0
+pkgdesc="TUI that lets you pick paths out of its stdin and run arbitrary commands on them"
+url="https://facebook.github.io/PathPicker"
+arch="noarch"
+license="MIT"
+depends="bash python3"
+subpackages="$pkgname-doc"
+source="$pkgname-$pkgver.tar.gz::https://github.com/facebook/PathPicker/archive/$pkgver.tar.gz"
+builddir="$srcdir/PathPicker-$pkgver"
+
+check() {
+	fpp --version
+}
+
+prepare() {
+	default_prepare
+
+	rm -r "src/__tests__"
+}
+
+package() {
+	# library
+	install -Dm755 "fpp" -t "$pkgdir/usr/share/fpp"
+	cp -a src "$pkgdir/usr/share/fpp"
+
+	# entrypoint
+	install -dm755 "$pkgdir/usr/bin"
+	ln -s "/usr/share/fpp/fpp" "$pkgdir/usr/bin"
+
+	# documentation
+	install -Dm644 LICENSE -t "$pkgdir/usr/share/licenses/$pkgname"
+	install -Dm644 "debian/usr/share/man/man1/fpp.1" -t "$pkgdir/usr/share/man/man1"
+}
+
+sha512sums="
+65b6b077f437bd642ebf94c55be901aabc73f7b9c89e4522c4f51970c4d63d744ad8fa29cac06816851f63bcb81d0480e61d405231c582e9aca0f4e650949a97  fpp-0.9.2.tar.gz
+"
-- 
2.34.1

Sorry to bother you @mailinglist-bot,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping `@team/mentors`. You can also ask on IRC on `#alpine-devel` on irc.oftc.net. If no further activity occurs in this MR, Alpine developers may close it in the future.

Thanks for your contribution.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205363

Is there anything else I should do here, @team/mentors?

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205366

By the way, this patch is actually outdated. Please refer to the up-to-date version in the mailing list instead: https://lists.alpinelinux.org/~alpine/aports/patches/3799

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205368

Sadly the bridge does not support follow-up patches, it only looks for new patch sets apparently, and does not update existing merge requests. I've manually updated the merge request with the latest patch.

CC: @ddevault

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205628

On Sat, 11 Dec 2021 16:38:12 -0500, Thiago Perrotta wrote:
> +builddir="$srcdir/PathPicker-$pkgver"
> +
> +prepare() {

Running the command with `--version` is not a good check and can create a false idea that things are working while they aren't.

If the project has no test suite, just mention that and add `options="!check" # no test suite`.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205629

On Sat, 11 Dec 2021 16:38:12 -0500, Thiago Perrotta wrote:
> +builddir="$srcdir/PathPicker-$pkgver"
> +
> +prepare() {

And this fails now as well, as `fpp` is not in $PATH

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205630

Please make a new thread on the mailing list for subsequent revisions of your patch (i.e. don't use --in-reply-to).

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205648

I did this before, but the caveat is that it ends up creating several MRs in Gitlab, which must be manually closed.

c.f. https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests?scope=all&state=closed&search=urlwatch and https://lists.alpinelinux.org/~alpine/aports?search=urlwatch (note: in this case I forgot to add -v2, -v3 etc but the point still applies).

The current optimal (least noisy) way seems to be to use the Gitlab workflow, with a MR owned by the contributor. Which is a bit sad because I am a fan of the email workflow.


Anyway, noted, I will stop using `--in-reply-to` for the time being, thanks Drew.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205861

On Sat, 11 Dec 2021 16:38:12 -0500, Thiago Perrotta wrote:
> +builddir="$srcdir/PathPicker-$pkgver"
> +
> +prepare() {

Will do. Unfortunately I will have to create a new MR in order to do that. I will link to it from here once it's done.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205862

On Sat, 11 Dec 2021 16:38:12 -0500, Thiago Perrotta wrote:
> +builddir="$srcdir/PathPicker-$pkgver"
> +
> +prepare() {

This can be closed now, refer to https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29485 with the requested changes.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205864

Superseded by https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29485

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205867

Yeah, this is a known deficiency. There are plans to fix it but it requires several other pieces to be in place.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205942