~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 4

[PATCH] testing/9base: fix troff directory

Elaina Thompson <felinae@ulthar.cat>
Details
Message ID
<20211227210933.19791-1-felinae@ulthar.cat>
DKIM signature
missing
Download raw message
Patch: +1 -1
as is, the troff directory gets placed in the incorrect place due to mkdir
already creating the directory. this should fix that behavior.

Ps: first patch (anywhere) apologies if anything is wrong or sloppy
---
 testing/9base/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/9base/APKBUILD b/testing/9base/APKBUILD
index 9d77b93e..3e713d00 100644
--- a/testing/9base/APKBUILD
+++ b/testing/9base/APKBUILD
@@ -47,7 +47,7 @@ troff() {
	cd "$pkgdir"
	mkdir -p "$subpkgdir/usr/lib/9base/bin"
	mv "$pkgdir/usr/lib/9base/bin/troff" "$subpkgdir/usr/lib/9base/bin/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib"
	mv "$pkgdir/usr/lib/9base/lib/troff" "$subpkgdir/usr/lib/9base/lib/troff"
}

-- 
2.34.1
Details
Message ID
<164323440406.985.457524233491185548.gitlab.28920.6de92e3c80da2e52c027d3a8508a7de00ae11cd2@listserv.local>
In-Reply-To
<20211227210933.19791-1-felinae@ulthar.cat> (view parent)
DKIM signature
missing
Download raw message
Sorry to bother you @mailinglist-bot,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping `@xihh87`. You can also ask on IRC on `#alpine-devel` on irc.oftc.net. If no further activity occurs in this MR, Alpine developers may close it in the future.

Thanks for your contribution.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28920#note_209527
Details
Message ID
<164324702761.985.1250223049728674565.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local>
In-Reply-To
<20211227210933.19791-1-felinae@ulthar.cat> (view parent)
DKIM signature
missing
Download raw message
this needed to bump pkgrel to actually affect the package

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28920#note_209665

[PATCH v2] testing/9base: fix troff directory

Elaina Thompson <felinae@ulthar.cat>
Details
Message ID
<20220127180032.11025-1-felinae@ulthar.cat>
In-Reply-To
<164324702761.985.1250223049728674565.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -3
as is, the troff directory gets placed in the incorrect place due to mkdir
already creating the directory. this should fix that behavior.

Ps: first patch (anywhere) apologies if anything is wrong or sloppy
---
Changes v1 -> v2
	- increment pkgrel
	- remove quotes in pkgname to resolve linting error

 testing/9base/APKBUILD | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testing/9base/APKBUILD b/testing/9base/APKBUILD
index 9d77b93e46..f5ab3d70ad 100644
--- a/testing/9base/APKBUILD
+++ b/testing/9base/APKBUILD
@@ -1,8 +1,8 @@
# Contributor: Joshua Haase <hahj87@gmail.com>
# Maintainer: Joshua Haase <hahj87@gmail.com>
pkgname="9base"
pkgname=9base
pkgver=6
pkgrel=0
pkgrel=1
pkgdesc="A port of various Plan 9 tools for Unix."
url="https://tools.suckless.org/9base/"
arch="all !armv7 !armhf !aarch64 !mips !mips64" # Needs arch specific config.mk
@@ -47,7 +47,7 @@ troff() {
	cd "$pkgdir"
	mkdir -p "$subpkgdir/usr/lib/9base/bin"
	mv "$pkgdir/usr/lib/9base/bin/troff" "$subpkgdir/usr/lib/9base/bin/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib"
	mv "$pkgdir/usr/lib/9base/lib/troff" "$subpkgdir/usr/lib/9base/lib/troff"
}

-- 
2.34.1
Details
Message ID
<164330699467.985.764433643299424574.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local>
In-Reply-To
<164324702761.985.1250223049728674565.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Patch: +3 -3
Elaina Thompson <felinae@ulthar.cat> replied via email:

```
as is, the troff directory gets placed in the incorrect place due to mkdir
already creating the directory. this should fix that behavior.

Ps: first patch (anywhere) apologies if anything is wrong or sloppy
---
Changes v1 -> v2
	- increment pkgrel
	- remove quotes in pkgname to resolve linting error

 testing/9base/APKBUILD | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testing/9base/APKBUILD b/testing/9base/APKBUILD
index 9d77b93e46..f5ab3d70ad 100644
--- a/testing/9base/APKBUILD
+++ b/testing/9base/APKBUILD
@@ -1,8 +1,8 @@
# Contributor: Joshua Haase <hahj87@gmail.com>
# Maintainer: Joshua Haase <hahj87@gmail.com>
pkgname="9base"
pkgname=9base
pkgver=6
pkgrel=0
pkgrel=1
pkgdesc="A port of various Plan 9 tools for Unix."
url="https://tools.suckless.org/9base/"
arch="all !armv7 !armhf !aarch64 !mips !mips64" # Needs arch specific config.mk
@@ -47,7 +47,7 @@ troff() {
	cd "$pkgdir"
	mkdir -p "$subpkgdir/usr/lib/9base/bin"
	mv "$pkgdir/usr/lib/9base/bin/troff" "$subpkgdir/usr/lib/9base/bin/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib/troff"
	mkdir -p "$subpkgdir/usr/lib/9base/lib"
	mv "$pkgdir/usr/lib/9base/lib/troff" "$subpkgdir/usr/lib/9base/lib/troff"
}

-- 
2.34.1


```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28920#note_209925
Details
Message ID
<164330739725.985.8180229609603333055.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local>
In-Reply-To
<164330699467.985.764433643299424574.gitlab.28920.c31feae4ca246a80638a0ee92aad49fab648f01c@listserv.local> (view parent)
DKIM signature
missing
Download raw message
ah, that doesn't actually work- you need to send a new patch that will open a new merge request.  
(or just make a gitlab account and use the normal merge flow)

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28920#note_209930
Reply to thread Export thread (mbox)