~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
7 3

[PATCH 1/3] testing/wlrobs: enable more arches

Drew DeVault <sir@cmpwn.com>
Details
Message ID
<20220215092012.22188-1-sir@cmpwn.com>
DKIM signature
missing
Download raw message
3 years ago
Patch: +1 -1 
---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 7431e62265..353bcc0c3c 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -4,7 +4,7 @@ pkgver=1.0
pkgrel=1
pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
url="https://hg.sr.ht/~scoopta/wlrobs"
arch="x86 x86_64" # obs-stduio not provided on other platforms
arch="all"
license="GPL-3.0-only"
makedepends="meson ninja obs-studio-dev wayland-dev"
source="https://dev.alpinelinux.org/archive/wlrobs/wlrobs-$pkgver.tar.gz "
-- 
2.35.1

[PATCH 3/3] testing/wlrobs: bump pkgrel

Drew DeVault <sir@cmpwn.com>
Details
Message ID
<20220215092012.22188-3-sir@cmpwn.com>
In-Reply-To
<20220215092012.22188-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
3 years ago
Patch: +1 -1 
---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 3edd554cb4..3db1e242ff 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -1,7 +1,7 @@
# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
pkgname=wlrobs
pkgver=1.0
pkgrel=1
pkgrel=2
pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
url="https://hg.sr.ht/~scoopta/wlrobs"
arch="all"
-- 
2.35.1

[PATCH 2/3] testing/wlrobs: add libdrm and mesa dependencies

Drew DeVault <sir@cmpwn.com>
Details
Message ID
<20220215092012.22188-2-sir@cmpwn.com>
In-Reply-To
<20220215092012.22188-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
3 years ago
Patch: +1 -1 
This causes the dmabuf backend to be built.
---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 353bcc0c3c..3edd554cb4 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -6,7 +6,7 @@ pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
url="https://hg.sr.ht/~scoopta/wlrobs"
arch="all"
license="GPL-3.0-only"
makedepends="meson ninja obs-studio-dev wayland-dev"
makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"
source="https://dev.alpinelinux.org/archive/wlrobs/wlrobs-$pkgver.tar.gz "
builddir="$srcdir/$pkgname-v$pkgver"
options="!check" # No tests provided
-- 
2.35.1

Re: [PATCH 2/3] testing/wlrobs: add libdrm and mesa dependencies

Jakub Jirutka <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<164492055455.985.5048047369175059824.gitlab.30934.8866b4ff5066b0b2fb6490fbce1983a2fd512ef2@listserv.local>
In-Reply-To
<20220215092012.22188-2-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
3 years ago 
On Tue, 15 Feb 2022 10:20:11 +0100, Drew DeVault wrote:
>  license="GPL-3.0-only"
> -makedepends="meson ninja obs-studio-dev wayland-dev"
> +makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

Please keep them sorted alphabeticaly and preferably reformat them to one item per line.

```diff
-makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"
+makedepends="
+	libdrm-dev
+	mesa-dev
+	meson
+	ninja
+	obs-studio-dev
+	wayland-dev
+	"
```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215518
Jakub Jirutka <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<164492093405.985.7669585068295697166.gitlab.30934.c88a36c8591f72380e48212db9dcbe7e37a76e97@listserv.local>
In-Reply-To
<20220215092012.22188-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
3 years ago 
Thanks for splitting independent changes into separate commits. However, splitting pkgrel bump is unnecessary, you can do it in the first commit of MR.

Also, please don’t open a new MR for the same thing, just amend commits to the original one.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215519
Drew DeVault <sir@cmpwn.com>
Details
Message ID
<CHWJTEVGU84G.2YLAMC6XD3939@taiga>
In-Reply-To
<164492093405.985.7669585068295697166.gitlab.30934.c88a36c8591f72380e48212db9dcbe7e37a76e97@listserv.local> (view parent)
DKIM signature
missing
Download raw message
3 years ago 
On Tue Feb 15, 2022 at 11:28 AM CET, Jakub Jirutka wrote:
> Thanks for splitting independent changes into separate commits.
> However, splitting pkgrel bump is unnecessary, you can do it in the
> first commit of MR.
>
> Also, please don’t open a new MR for the same thing, just amend
> commits to the original one.

I contribute via email, which does not support new MRs. Sorry.
mailinglist-bot <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<164492097507.985.2510082796146486104.gitlab.30934.c88a36c8591f72380e48212db9dcbe7e37a76e97@listserv.local>
In-Reply-To
<164492093405.985.7669585068295697166.gitlab.30934.c88a36c8591f72380e48212db9dcbe7e37a76e97@listserv.local> (view parent)
DKIM signature
missing
Download raw message
3 years ago 
Drew DeVault <sir@cmpwn.com> replied via email:

```
On Tue Feb 15, 2022 at 11:28 AM CET, Jakub Jirutka wrote:
> Thanks for splitting independent changes into separate commits.
> However, splitting pkgrel bump is unnecessary, you can do it in the
> first commit of MR.
>
> Also, please don’t open a new MR for the same thing, just amend
> commits to the original one.

I contribute via email, which does not support new MRs. Sorry.

```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215520
Jakub Jirutka <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<164493140955.985.18156345499379764621.gitlab.30934.e5247820be8687f88cd49b829b77e74c3e2de87f@listserv.local>
In-Reply-To
<20220215092012.22188-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
3 years ago 
Superseded by !30936.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215556
Reply to thread Export thread (mbox)