testing/wlrobs: enable more arches v1 REJECTED

Drew DeVault: 3
 testing/wlrobs: enable more arches
 testing/wlrobs: add libdrm and mesa dependencies
 testing/wlrobs: bump pkgrel

 3 files changed, 3 insertions(+), 3 deletions(-)

Drew DeVault <sir@cmpwn.com> replied via email:

```
On Tue Feb 15, 2022 at 11:28 AM CET, Jakub Jirutka wrote:

[PATCH 1/3] testing/wlrobs: enable more arches Export this patch

---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 7431e62265..353bcc0c3c 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -4,7 +4,7 @@ pkgver=1.0
 pkgrel=1
 pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
 url="https://hg.sr.ht/~scoopta/wlrobs"
-arch="x86 x86_64" # obs-stduio not provided on other platforms
+arch="all"
 license="GPL-3.0-only"
 makedepends="meson ninja obs-studio-dev wayland-dev"
 source="https://dev.alpinelinux.org/archive/wlrobs/wlrobs-$pkgver.tar.gz "
-- 
2.35.1

Jakub Jirutka <no-reply@dispatch.alpinelinux.org>

2 years ago

Thanks for splitting independent changes into separate commits. However, splitting pkgrel bump is unnecessary, you can do it in the first commit of MR.

Also, please don’t open a new MR for the same thing, just amend commits to the original one.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215519

Jakub Jirutka <no-reply@dispatch.alpinelinux.org>

2 years ago

Superseded by !30936.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215556

[PATCH 2/3] testing/wlrobs: add libdrm and mesa dependencies Export this patch

This causes the dmabuf backend to be built.
---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 353bcc0c3c..3edd554cb4 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -6,7 +6,7 @@ pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
 url="https://hg.sr.ht/~scoopta/wlrobs"
 arch="all"
 license="GPL-3.0-only"
-makedepends="meson ninja obs-studio-dev wayland-dev"
+makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

Jakub Jirutka <no-reply@dispatch.alpinelinux.org>

2 years ago

Please keep them sorted alphabeticaly and preferably reformat them to one item per line.

```diff
-makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"
+makedepends="
+	libdrm-dev
+	mesa-dev
+	meson
+	ninja
+	obs-studio-dev
+	wayland-dev
+	"
```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934#note_215518

 source="https://dev.alpinelinux.org/archive/wlrobs/wlrobs-$pkgver.tar.gz "
 builddir="$srcdir/$pkgname-v$pkgver"
 options="!check" # No tests provided
-- 
2.35.1

[PATCH 3/3] testing/wlrobs: bump pkgrel Export this patch

---
 testing/wlrobs/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 3edd554cb4..3db1e242ff 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -1,7 +1,7 @@
 # Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
 pkgname=wlrobs
 pkgver=1.0
-pkgrel=1
+pkgrel=2
 pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
 url="https://hg.sr.ht/~scoopta/wlrobs"
 arch="all"
-- 
2.35.1