~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 2

[PATCH 1/2] community/libcamera: remove boost from dependencies

Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Details
Message ID
<20230114163844.10487-1-jacopo.mondi@ideasonboard.com>
DKIM signature
missing
Download raw message
2 months ago
Patch: +0 -1 
Boost is not required anymore to build libcamera since the dependency
has been dropped in commit c1597f989654 ("ipa: raspberrypi: Use
YamlParser to replace dependency on boost").

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 community/libcamera/APKBUILD | 1 -
 1 file changed, 1 deletion(-)

diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
index 1399bcda0f74..1bf0015ec127 100644
--- a/community/libcamera/APKBUILD
+++ b/community/libcamera/APKBUILD
@@ -8,7 +8,6 @@ url="https://libcamera.org/"
arch="all"
license="LGPL-2.1-or-later AND GPL-2.0-or-later"
depends_dev="
	boost-dev
	eudev-dev
	glib-dev
	gnutls-dev
-- 
2.39.0

[PATCH 2/2] community/libcamera: add sdl2 dependency for cam

Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Details
Message ID
<20230114163844.10487-2-jacopo.mondi@ideasonboard.com>
In-Reply-To
<20230114163844.10487-1-jacopo.mondi@ideasonboard.com> (view parent)
DKIM signature
missing
Download raw message
2 months ago
Patch: +2 -0 
The cam test tol can preview frames using SDL2 if available during
compilation.

Add sdl2 and sdl2_image to the dependencies list.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
This is only required for the cam test tool and should probably be made a
libcamera-tools sub-package dependency. Not sure if this can be expressed in
APKBUILD.

 community/libcamera/APKBUILD | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
index 1bf0015ec127..252c879e784d 100644
--- a/community/libcamera/APKBUILD
+++ b/community/libcamera/APKBUILD
@@ -13,6 +13,8 @@ depends_dev="
	gnutls-dev
	gst-plugins-bad-dev
	qt5-qtbase-dev
	sdl2-dev
	sdl2_image-dev
	"
# upstream calls 'date' with a non-POSIX option so we pull in coreutils
makedepends="$depends_dev
--
2.39.0
Kevin Daudt <kdaudt@alpinelinux.org>
Details
Message ID
<Y8ZAcVIYWi66ml2s@bbea3f19b1bb>
In-Reply-To
<20230114163844.10487-1-jacopo.mondi@ideasonboard.com> (view parent)
DKIM signature
missing
Download raw message
2 months ago 
On Sat, Jan 14, 2023 at 05:38:43PM +0100, Jacopo Mondi wrote:
> Boost is not required anymore to build libcamera since the dependency
> has been dropped in commit c1597f989654 ("ipa: raspberrypi: Use
> YamlParser to replace dependency on boost").
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>  community/libcamera/APKBUILD | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
> index 1399bcda0f74..1bf0015ec127 100644
> --- a/community/libcamera/APKBUILD
> +++ b/community/libcamera/APKBUILD
> @@ -8,7 +8,6 @@ url="https://libcamera.org/"
>  arch="all"
>  license="LGPL-2.1-or-later AND GPL-2.0-or-later"
>  depends_dev="
> -	boost-dev
>  	eudev-dev
>  	glib-dev
>  	gnutls-dev
> -- 
> 2.39.0
> 

FYI, you need to bump the pkgrel, otherwise the package does not get
rebuilt.
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Details
Message ID
<20230123111724.pz2ixbmrjvr5i3ua@uno.localdomain>
In-Reply-To
<Y8ZAcVIYWi66ml2s@bbea3f19b1bb> (view parent)
DKIM signature
missing
Download raw message
2 months ago 
Hi Kevin

On Tue, Jan 17, 2023 at 06:30:09AM +0000, Kevin Daudt wrote:
> On Sat, Jan 14, 2023 at 05:38:43PM +0100, Jacopo Mondi wrote:
> > Boost is not required anymore to build libcamera since the dependency
> > has been dropped in commit c1597f989654 ("ipa: raspberrypi: Use
> > YamlParser to replace dependency on boost").
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > ---
> >  community/libcamera/APKBUILD | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
> > index 1399bcda0f74..1bf0015ec127 100644
> > --- a/community/libcamera/APKBUILD
> > +++ b/community/libcamera/APKBUILD
> > @@ -8,7 +8,6 @@ url="https://libcamera.org/"
> >  arch="all"
> >  license="LGPL-2.1-or-later AND GPL-2.0-or-later"
> >  depends_dev="
> > -	boost-dev
> >  	eudev-dev
> >  	glib-dev
> >  	gnutls-dev
> > --
> > 2.39.0
> >
>
> FYI, you need to bump the pkgrel, otherwise the package does not get
> rebuilt.

Ah thanks, will fix and resend soon!
Kevin Daudt <kdaudt@alpinelinux.org>
Details
Message ID
<Y85tDhK716t+KntA@7a0aac3667e2>
In-Reply-To
<20230123111724.pz2ixbmrjvr5i3ua@uno.localdomain> (view parent)
DKIM signature
missing
Download raw message
2 months ago 
On Mon, Jan 23, 2023 at 12:17:24PM +0100, Jacopo Mondi wrote:
> Hi Kevin
> 
> On Tue, Jan 17, 2023 at 06:30:09AM +0000, Kevin Daudt wrote:
> > On Sat, Jan 14, 2023 at 05:38:43PM +0100, Jacopo Mondi wrote:
> > > Boost is not required anymore to build libcamera since the dependency
> > > has been dropped in commit c1597f989654 ("ipa: raspberrypi: Use
> > > YamlParser to replace dependency on boost").
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > > ---
> > >  community/libcamera/APKBUILD | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
> > > index 1399bcda0f74..1bf0015ec127 100644
> > > --- a/community/libcamera/APKBUILD
> > > +++ b/community/libcamera/APKBUILD
> > > @@ -8,7 +8,6 @@ url="https://libcamera.org/"
> > >  arch="all"
> > >  license="LGPL-2.1-or-later AND GPL-2.0-or-later"
> > >  depends_dev="
> > > -	boost-dev
> > >  	eudev-dev
> > >  	glib-dev
> > >  	gnutls-dev
> > > --
> > > 2.39.0
> > >
> >
> > FYI, you need to bump the pkgrel, otherwise the package does not get
> > rebuilt.
> 
> Ah thanks, will fix and resend soon!

FYI, the MR[0] has already been merged.

[0]: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/43267
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Details
Message ID
<20230123113521.ibtgnryx4drvl6kd@uno.localdomain>
In-Reply-To
<Y85tDhK716t+KntA@7a0aac3667e2> (view parent)
DKIM signature
missing
Download raw message
2 months ago 
Hi Kevin

On Mon, Jan 23, 2023 at 11:18:38AM +0000, Kevin Daudt wrote:
> On Mon, Jan 23, 2023 at 12:17:24PM +0100, Jacopo Mondi wrote:
> > Hi Kevin
> >
> > On Tue, Jan 17, 2023 at 06:30:09AM +0000, Kevin Daudt wrote:
> > > On Sat, Jan 14, 2023 at 05:38:43PM +0100, Jacopo Mondi wrote:
> > > > Boost is not required anymore to build libcamera since the dependency
> > > > has been dropped in commit c1597f989654 ("ipa: raspberrypi: Use
> > > > YamlParser to replace dependency on boost").
> > > >
> > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > > > ---
> > > >  community/libcamera/APKBUILD | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/community/libcamera/APKBUILD b/community/libcamera/APKBUILD
> > > > index 1399bcda0f74..1bf0015ec127 100644
> > > > --- a/community/libcamera/APKBUILD
> > > > +++ b/community/libcamera/APKBUILD
> > > > @@ -8,7 +8,6 @@ url="https://libcamera.org/"
> > > >  arch="all"
> > > >  license="LGPL-2.1-or-later AND GPL-2.0-or-later"
> > > >  depends_dev="
> > > > -	boost-dev
> > > >  	eudev-dev
> > > >  	glib-dev
> > > >  	gnutls-dev
> > > > --
> > > > 2.39.0
> > > >
> > >
> > > FYI, you need to bump the pkgrel, otherwise the package does not get
> > > rebuilt.
> >
> > Ah thanks, will fix and resend soon!
>
> FYI, the MR[0] has already been merged.
>
> [0]: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/43267

I noticed as soon as I've re-fetch the repo. Sorry I was not following
gitlab and thanks for fixing the not-required sdl2_image dependency
which indeed seems a leftover.

Cheers
Reply to thread Export thread (mbox)