1

RE: [alpine-aports] [PATCH] testing/libgflags: new aport

David Huffman
Details
Message ID
<BAY403-EAS960A43844468A5F50907F3B2F70@phx.gbl>
Sender timestamp
1452360213
DKIM signature
missing
Download raw message
Since it only provides a library and not an application, I figured it would be preferable for organization purposes. Was I wrong?

(Sorry about you getting this twice, my email client apparently isn’t a fan of replying to mailing lists without some coercion.)
Warm regards,

David Huffman


From: Sören Tempel
Sent: Saturday, January 9, 2016 10:29 AM
To: alpine-aports@lists.alpinelinux.org
Cc: storedbox@outlook.com
Subject: Re: [alpine-aports] [PATCH] testing/libgflags: new aport

On 09.01.16, David Huffman wrote:
> +# Contributor: David Huffman <storedbox@outlook.com>
> +# Maintainer: David Huffman <storedbox@outlook.com>
> +pkgname=libgflags
> +pkgver=2.1.2
> +_srcname=gflags-$pkgver

Is there any reason why you called the package libgflags instead of
simply naming it gflags? Than you wouldn't need the _srcname variable...

Sören.

Re: [alpine-aports] [PATCH] testing/libgflags: new aport

Timo Teras
Details
Message ID
<20160119143548.6014fcd5@vostro>
In-Reply-To
<BAY403-EAS960A43844468A5F50907F3B2F70@phx.gbl> (view parent)
Sender timestamp
1453206948
DKIM signature
missing
Download raw message
On Sat, 9 Jan 2016 12:23:33 -0500
David Huffman <storedbox@outlook.com> wrote:

> Since it only provides a library and not an application, I figured it
> would be preferable for organization purposes. Was I wrong?
> 
> (Sorry about you getting this twice, my email client apparently isn’t
> a fan of replying to mailing lists without some coercion.) Warm
> regards,

Yes, this is the standard practice. library-only stuff is usually
prefixed with lib.

The aport looks good with the exception that it installs:
usr/bin/gflags_completions.sh

Either delete it or make it a subpkg with install_if for bash. See tmux
or grep "bash-completion" in the main/*/APKBUILD for examples.

Please resend that fixed, and I'm happy to apply it.

Thanks,
Timo


> David Huffman
> 
> 
> From: Sören Tempel
> Sent: Saturday, January 9, 2016 10:29 AM
> To: alpine-aports@lists.alpinelinux.org
> Cc: storedbox@outlook.com
> Subject: Re: [alpine-aports] [PATCH] testing/libgflags: new aport
> 
> On 09.01.16, David Huffman wrote:
> > +# Contributor: David Huffman <storedbox@outlook.com>
> > +# Maintainer: David Huffman <storedbox@outlook.com>
> > +pkgname=libgflags
> > +pkgver=2.1.2
> > +_srcname=gflags-$pkgver  
> 
> Is there any reason why you called the package libgflags instead of
> simply naming it gflags? Than you wouldn't need the _srcname
> variable...
> 
> Sören.
> 



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---