testing/klavaro: new aport v1 NEEDS REVISION

VÖRÖSKŐI András: 1
 testing/klavaro: new aport

 2 files changed, 32 insertions(+), 0 deletions(-)

Hi Leo,

Thanks for reviewing!

On Sat Jan 11, 2020 at 2:15 AM, Leo wrote:

[PATCH] testing/klavaro: new aport Export this patch

https://klavaro.sourceforge.io
Free touch typing tutor program
---
 testing/klavaro/APKBUILD             | 29 ++++++++++++++++++++++++++++
 testing/klavaro/klavaro.post-install |  3 +++
 2 files changed, 32 insertions(+)
 create mode 100644 testing/klavaro/APKBUILD
 create mode 100644 testing/klavaro/klavaro.post-install

diff --git a/testing/klavaro/APKBUILD b/testing/klavaro/APKBUILD
new file mode 100644
index 0000000000..7aaf1fd3cd
--- /dev/null
+++ b/testing/klavaro/APKBUILD
@@ -0,0 +1,29 @@
+# Contributor: Fabio Riga <rifabio@dpersonam.me>
+# Maintainer: VÖRÖSKŐI András <voroskoi@gmail.com>
+pkgname=klavaro
+pkgver=3.09
+pkgrel=0
+pkgdesc="Free touch typing tutor program."
+url="http://klavaro.sourceforge.io/"
+arch="all"
+license="GPL-3.0-or-later"
+depends="curl gtk+3.0 hicolor-icon-theme"
+makedepends="intltool gtk+3.0-dev curl-dev"
+install="$pkgname.post-install"
+subpackages="$pkgname-lang $pkgname-doc"
+source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.bz2"
+
+build() {
+        ./configure --prefix=/usr
+        make
+}
+
+package() {
+        make DESTDIR="$pkgdir" install
+        # remove the gtkdatabox shared library
+        # klavaro links to it statically due to some incompatibility with GTK3
+        rm -r "$pkgdir/usr/lib"
+        # remove gtkdatabox include files
+        rm -r "$pkgdir/usr/include"
+}
+sha512sums="a2f601dd7f41f6e5a11273cfe4b0261113350d8169b35983fd6a97c34d48b0145fcb2a426e81ef88435cdb29dfe89c2923e4887a2488cb99db6dd6778a9dc86a  klavaro-3.09.tar.bz2"
diff --git a/testing/klavaro/klavaro.post-install b/testing/klavaro/klavaro.post-install
new file mode 100644
index 0000000000..537a77db9b
--- /dev/null
+++ b/testing/klavaro/klavaro.post-install
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+gtk-update-icon-cache -f /usr/share/icons/hicolor
-- 
2.24.1

Leo <thinkabit.ukim@gmail.com>

4 years ago

All the lines contain ^M, which breaks everything. Please use a UNIX
environment (preferably Alpine) while creating patches.

Please use tabs instead of spaces for indentation.

No need for that post-install script, GTK already has a trigger for it.

Lastly your program segfaults when starting on Wayland, only when you
didn't start it already on X11.