~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH] testing/klavaro: new aport

VÖRÖSKŐI András <voroskoi@gmail.com>
Details
Message ID
<20200110185159.23429-1-voroskoi@gmail.com>
DKIM signature
missing
Download raw message
Patch: +32 -0
https://klavaro.sourceforge.io
Free touch typing tutor program
---
 testing/klavaro/APKBUILD             | 29 ++++++++++++++++++++++++++++
 testing/klavaro/klavaro.post-install |  3 +++
 2 files changed, 32 insertions(+)
 create mode 100644 testing/klavaro/APKBUILD
 create mode 100644 testing/klavaro/klavaro.post-install

diff --git a/testing/klavaro/APKBUILD b/testing/klavaro/APKBUILD
new file mode 100644
index 0000000000..7aaf1fd3cd
--- /dev/null
+++ b/testing/klavaro/APKBUILD
@@ -0,0 +1,29 @@
# Contributor: Fabio Riga <rifabio@dpersonam.me>
# Maintainer: VÖRÖSKŐI András <voroskoi@gmail.com>
pkgname=klavaro
pkgver=3.09
pkgrel=0
pkgdesc="Free touch typing tutor program."
url="http://klavaro.sourceforge.io/"
arch="all"
license="GPL-3.0-or-later"
depends="curl gtk+3.0 hicolor-icon-theme"
makedepends="intltool gtk+3.0-dev curl-dev"
install="$pkgname.post-install"
subpackages="$pkgname-lang $pkgname-doc"
source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.bz2"

build() {
        ./configure --prefix=/usr
        make
}

package() {
        make DESTDIR="$pkgdir" install
        # remove the gtkdatabox shared library
        # klavaro links to it statically due to some incompatibility with GTK3
        rm -r "$pkgdir/usr/lib"
        # remove gtkdatabox include files
        rm -r "$pkgdir/usr/include"
}
sha512sums="a2f601dd7f41f6e5a11273cfe4b0261113350d8169b35983fd6a97c34d48b0145fcb2a426e81ef88435cdb29dfe89c2923e4887a2488cb99db6dd6778a9dc86a  klavaro-3.09.tar.bz2"
diff --git a/testing/klavaro/klavaro.post-install b/testing/klavaro/klavaro.post-install
new file mode 100644
index 0000000000..537a77db9b
--- /dev/null
+++ b/testing/klavaro/klavaro.post-install
@@ -0,0 +1,3 @@
#!/bin/sh

gtk-update-icon-cache -f /usr/share/icons/hicolor
-- 
2.24.1
Details
Message ID
<20200111021503.053e156c@enterprise>
In-Reply-To
<20200110185159.23429-1-voroskoi@gmail.com> (view parent)
DKIM signature
missing
Download raw message
All the lines contain ^M, which breaks everything. Please use a UNIX
environment (preferably Alpine) while creating patches.

Please use tabs instead of spaces for indentation.

No need for that post-install script, GTK already has a trigger for it.

Lastly your program segfaults when starting on Wayland, only when you
didn't start it already on X11.
VÖRÖSKŐI András <voroskoi@gmail.com>
Details
Message ID
<BZT8LWEZXO7D.OD1Z703DL76Q@parittya>
In-Reply-To
<20200111021503.053e156c@enterprise> (view parent)
DKIM signature
missing
Download raw message
Hi Leo,

Thanks for reviewing!

On Sat Jan 11, 2020 at 2:15 AM, Leo wrote:
> All the lines contain ^M, which breaks everything. Please use a UNIX
> environment (preferably Alpine) while creating patches.

I did actually. Also 'dos2unix -u APKBUILD' does nothing with the file.
OTOH dos2unix -d appens those ^Ms to each line. What am I doing wrong?

> Please use tabs instead of spaces for indentation.

By bad. Fixed.

> No need for that post-install script, GTK already has a trigger for it.

Thanks. Removed.

> Lastly your program segfaults when starting on Wayland, only when you
> didn't start it already on X11.

I need some time for this one as I do not use wayland (yet). I will try
to reproduce and fix it.

Thanks,
Reply to thread Export thread (mbox)