~alpine/devel

2 2

[alpine-devel] new aport apcupsd

Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<9334be8a0901210253g7fd84172m78626db868552121@mail.gmail.com>
Sender timestamp
1232535204
DKIM signature
missing
Download raw message
Please review attached patch

Leo
Details
Message ID
<1232543361.1947.178.camel@nc>
In-Reply-To
<9334be8a0901210253g7fd84172m78626db868552121@mail.gmail.com> (view parent)
Sender timestamp
1232543361
DKIM signature
missing
Download raw message

On Wed, 2009-01-21 at 11:53 +0100, Leonardo Arena wrote:
> Please review attached patch
> 
> Leo 

Thanks!

...

> 
> 
> 
> 
> +depends="uclibc util-linux-ng"
> +makedepends="g++"
> +source="http://surfnet.dl.sourceforge.net/sourceforge/apcupsd/apcupsd-3.14.5.tar.gz"

please use download.sourceforge.net rather than a specific sf mirror.
Also, if you use $pkgver in the source url, then you only need to change
the version number in pkgver when upgrading the package.

source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.gz"

> +
> +build() {
> +       cd "$srcdir/$pkgname-$pkgver"
> +
> +       ./configure --prefix=/usr \
> +       --mandir=/usr/share/man
> +       --enable-usb
> +       make || return 1
> +       make DESTDIR=$pkgdir install
> +}
> +
> +md5sums="4ac73ec91d8ab56f3fac894e172567c4  apcupsd-3.14.5.tar.gz"
> -- 
> 1.6.1
> 

Otherwise looks good. It needs an init.d script i suppose and we need to
check up if we can use busybox halt rather than depend on util-linux-ng
shutdown.

Hm... it looks like it needs 'wall'. Maybe just keep that util-linux-ng
there.

I alos copied the init.d script from gentoo.

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<9334be8a0901210513m61739c34r33dfa102363da543@mail.gmail.com>
In-Reply-To
<1232543361.1947.178.camel@nc> (view parent)
Sender timestamp
1232543618
DKIM signature
missing
Download raw message
On Wed, Jan 21, 2009 at 2:09 PM, Natanael Copa <natanael.copa@gmail.com>wrote:


> > +depends="uclibc util-linux-ng"
> > +makedepends="g++"
> > +source="
> http://surfnet.dl.sourceforge.net/sourceforge/apcupsd/apcupsd-3.14.5.tar.gz
> "
>
> please use download.sourceforge.net rather than a specific sf mirror.
> Also, if you use $pkgver in the source url, then you only need to change
> the version number in pkgver when upgrading the package.
>
> source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.gz"


ok, right


>
> Otherwise looks good. It needs an init.d script i suppose and we need to
> check up if we can use busybox halt rather than depend on util-linux-ng
> shutdown.
>
> Hm... it looks like it needs 'wall'. Maybe just keep that util-linux-ng
> there.
>
> I alos copied the init.d script from gentoo.
>
> -nc
>
> Thanks!
Reply to thread Export thread (mbox)