1

[alpine-devel] [PATCH] multipath-tools: fixing the way to call functions

Sergey T
Details
Message ID
<CAOoJqMdXw-uL_6B1S=CQQv97=FBJRdMyyhoHpspi91=ZZui84g@mail.gmail.com>
Sender timestamp
1413551153
DKIM signature
missing
Download raw message
Patch: +2 -2
Dear friends,

It would be better to remove "()" in undo_nodes() and do_nodes() strings
because /sbin/runscript actually does not call functions this way.

Regards.
-Sheavy

--- aports/main/multipath-tools/multipath-tools.initd.orig
+++ aports/main/multipath-tools/multipath-tools.initd
@@ -25,13 +25,13 @@
  ebegin "Starting multipathd"
  start-stop-daemon --start --quiet --make-pidfile \
   --pidfile /var/run/multipathd.pid --exec /sbin/multipathd
- do_nodes()
+ do_nodes
  eend $?
 }

 stop() {
  ebegin "Stopping multipathd"
- undo_nodes()
+ undo_nodes
  start-stop-daemon --stop --quiet --retry --pidfile /var/run/multipathd.pid
  eend $?
 }
Leonardo Arena
Details
Message ID
<1413809359.16317.265.camel@df1844j>
In-Reply-To
<CAOoJqMdXw-uL_6B1S=CQQv97=FBJRdMyyhoHpspi91=ZZui84g@mail.gmail.com> (view parent)
Sender timestamp
1413809359
DKIM signature
missing
Download raw message
On ven, 2014-10-17 at 17:05 +0400, Sergey T wrote:
> Dear friends, 
> 
> 
> It would be better to remove "()" in undo_nodes() and do_nodes()
> strings because /sbin/runscript actually does not call functions this
> way.


Hi,
the patch failed to apply in GIT, but since it was simple fix I just
patched it manually in edge and 3.0-stable.
A GIT patch would be nicer next time.

Thank you!

- leo