For discussion of Alpine Linux development and developer support

5 4

[alpine-devel] [Proposal] Remove "# Contributors:" from APKBUILDs

Tmp File
Details
Message ID
<trinity-9f3437a2-9c6a-43d8-a5be-71264898e6fc-1499780412728@3capp-mailcom-lxa13>
Sender timestamp
1499780412
DKIM signature
missing
Download raw message
Hello Alpinists.

I think the contributors on an APKBUILD doesn't give much useful information and only makes the APKBUILDs longer.
In the off chance you want to see who contributed in the past to a package, you can use git log.
Most times only the maintainer is useful.
If he doesn't answer, you can look at whoever else contributed to the package with git log.
It'll be much more detailed and give a better idea.
As a good side-effect this would also make the maintainer of a package easier to parse.

How do you feel about it?
If you like it I can send PRs to deal with this.

Thank you.



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
William Pitcock
Details
Message ID
<CA+T2pCHmwUVKT0mw=BaQmjezf5gN3u1J_7cmXsHRKM-Q1igEOw@mail.gmail.com>
In-Reply-To
<trinity-9f3437a2-9c6a-43d8-a5be-71264898e6fc-1499780412728@3capp-mailcom-lxa13> (view parent)
Sender timestamp
1499842789
DKIM signature
missing
Download raw message
Hello,

On Tue, Jul 11, 2017 at 8:40 AM, Tmp File <tmpfile@mail.com> wrote:
> Hello Alpinists.
>
> I think the contributors on an APKBUILD doesn't give much useful information and only makes the APKBUILDs longer.
> In the off chance you want to see who contributed in the past to a package, you can use git log.
> Most times only the maintainer is useful.
> If he doesn't answer, you can look at whoever else contributed to the package with git log.
> It'll be much more detailed and give a better idea.
> As a good side-effect this would also make the maintainer of a package easier to parse.

I agree, however I also think allowing multiple Maintainer lines is important.
We may also want to keep Contributor lines for restricted packages
where only some people are allowed to touch them, but right now our
commit scripts don't do that specific kind of processing.

William


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Tmp File
Details
Message ID
<trinity-a9db1aeb-0c03-4c1c-84b1-d2414f62bd53-1499861982040@3capp-mailcom-lxa12>
In-Reply-To
<CA+T2pCHmwUVKT0mw=BaQmjezf5gN3u1J_7cmXsHRKM-Q1igEOw@mail.gmail.com> (view parent)
Sender timestamp
1499861982
DKIM signature
missing
Download raw message
> I agree
Good.
I'll try and send a PR later today or tomorrow removing "# Contributor:" and leaving only "# Maintainer:"

> however I also think allowing multiple Maintainer lines is important.
I have no opinion about multiple Maintainer lines.
You should discuss that with other people.
But I did found some different opinion on the bugtracker: https://bugs.alpinelinux.org/issues/5421


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20170712162518.51f4503e@ncopa-desktop.copa.dup.pw>
In-Reply-To
<CA+T2pCHmwUVKT0mw=BaQmjezf5gN3u1J_7cmXsHRKM-Q1igEOw@mail.gmail.com> (view parent)
Sender timestamp
1499869518
DKIM signature
missing
Download raw message
On Wed, 12 Jul 2017 01:59:49 -0500
William Pitcock <nenolod@dereferenced.org> wrote:

> Hello,
> 
> On Tue, Jul 11, 2017 at 8:40 AM, Tmp File <tmpfile@mail.com> wrote:
> > Hello Alpinists.
> >
> > I think the contributors on an APKBUILD doesn't give much useful information and only makes the APKBUILDs longer.
> > In the off chance you want to see who contributed in the past to a package, you can use git log.
> > Most times only the maintainer is useful.
> > If he doesn't answer, you can look at whoever else contributed to the package with git log.
> > It'll be much more detailed and give a better idea.
> > As a good side-effect this would also make the maintainer of a package easier to parse.  
> 
> I agree, however I also think allowing multiple Maintainer lines is important.

The idea with having a single maintainer is that one single person has
the responsability for the package. This is to avoid situation where
all the maintainers expect the other maintainers to act.

When you are alone maintainer there is no doubt who should follow up
and make sure things gets fixed.

I am open to add a field for multiple comaintainers though.

We should probably also change it from being a comment in apkbuild to a shell variable.

eg: 

maintainer="...."

> We may also want to keep Contributor lines for restricted packages
> where only some people are allowed to touch them, but right now our
> commit scripts don't do that specific kind of processing.
> 
> William
> 
> 
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
> 



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20170712163054.4b3ce65b@ncopa-desktop.copa.dup.pw>
In-Reply-To
<trinity-9f3437a2-9c6a-43d8-a5be-71264898e6fc-1499780412728@3capp-mailcom-lxa13> (view parent)
Sender timestamp
1499869854
DKIM signature
missing
Download raw message
On Tue, 11 Jul 2017 15:40:12 +0200
"Tmp File" <tmpfile@mail.com> wrote:

> Hello Alpinists.
> 
> I think the contributors on an APKBUILD doesn't give much useful information and only makes the APKBUILDs longer.
> In the off chance you want to see who contributed in the past to a package, you can use git log.
> Most times only the maintainer is useful.
> If he doesn't answer, you can look at whoever else contributed to the package with git log.
> It'll be much more detailed and give a better idea.
> As a good side-effect this would also make the maintainer of a package easier to parse.
> 
> How do you feel about it?

The contributors does not provide any vital information but I think it
is a nice way to give credit to people who contribute. Even if you do a
minor change, and even if you don't create the commit/patch, you can
still have your name there and be proud of have contributed.

> If you like it I can send PRs to deal with this.

I suppose you should ask the contributors in question how they feel
about it. If they are ok with it, then I am too.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
V.Krishn
Details
Message ID
<201707160501.12501.vkrishn4@gmail.com>
In-Reply-To
<20170712162518.51f4503e@ncopa-desktop.copa.dup.pw> (view parent)
Sender timestamp
1500161472
DKIM signature
missing
Download raw message
> On Wed, 12 Jul 2017 01:59:49 -0500
> 
> William Pitcock <nenolod@dereferenced.org> wrote:
> > Hello,
> > 
> > On Tue, Jul 11, 2017 at 8:40 AM, Tmp File <tmpfile@mail.com> wrote:
> > > Hello Alpinists.
> > > 
> > > I think the contributors on an APKBUILD doesn't give much useful
> > > information and only makes the APKBUILDs longer. In the off chance you
> > > want to see who contributed in the past to a package, you can use git
> > > log. Most times only the maintainer is useful.
> > > If he doesn't answer, you can look at whoever else contributed to the
> > > package with git log. It'll be much more detailed and give a better
> > > idea.
> > > As a good side-effect this would also make the maintainer of a package
> > > easier to parse.
> > 
> > I agree, however I also think allowing multiple Maintainer lines is
> > important.
> 
> The idea with having a single maintainer is that one single person has
> the responsability for the package. This is to avoid situation where
> all the maintainers expect the other maintainers to act.
> 
> When you are alone maintainer there is no doubt who should follow up
> and make sure things gets fixed.
> 
> I am open to add a field for multiple comaintainers though.

This is were adding auto-flagging in https://pkgs.alpinelinux.org/flagged 
interface could be a help.
The scripts checks the ordered (occurrence) of maintainers in apkbuild file.

Moment a new version of pkg is auto flagged, it emails to first maintainer.
(or the next depending on stats)

Once maintainer acts upon the email he/she can send back mqtt msg with some 
pre-defined msg (the mqtt pub format can be normalized). 

The msg triggers a increment count for that maintainer for WIP or pkgs.
The number of pkgs a maintainer can tag as WIP can be set as quota,
or there can be round-robin on multi-maintainer'ed pkgs.

Interface https://pkgs.alpinelinux.org/flagged can be enhanced,
1. Message columns would show the current state
2. Have a Msg history link
3. Stats page for maintainers showing work in hand

Having he whole cli based with web-based gui wrapper may be more desirable.

> 
> We should probably also change it from being a comment in apkbuild to a
> shell variable.

May not be needed.

> 
> eg:
> 
> maintainer="...."
> 
> > We may also want to keep Contributor lines for restricted packages
> > where only some people are allowed to touch them, but right now our
> > commit scripts don't do that specific kind of processing.
> > 
> > William
> > 
> > 
> > ---
> > Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> > Help:         alpine-devel+help@lists.alpinelinux.org
> > ---
> 
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
-- 
Regards.
V.Krishn


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---