~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[PATCH] testing/tre: new aport

Al-Hassan Abdel-Raouf <alhassanaraouf@disroot.org>
Details
Message ID
<20201014080446.15248-1-alhassanaraouf@disroot.org>
DKIM signature
missing
Download raw message
Patch: +25 -0
https://laurikari.net/tre
POSIX compliant regexp matching library.
Includes agrep for approximate grepping.
---
 testing/tre/APKBUILD | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 testing/tre/APKBUILD

diff --git a/testing/tre/APKBUILD b/testing/tre/APKBUILD
new file mode 100644
index 0000000000..4eb0e68fe4
--- /dev/null
+++ b/testing/tre/APKBUILD
@@ -0,0 +1,25 @@
# Contributor:
# Maintainer:
pkgname=tre
pkgver=0.8.0
pkgrel=0
pkgdesc="POSIX compliant regexp matching library. Includes agrep for approximate grepping."
url="https://laurikari.net/tre"
arch="all"
license="BSD"
depends="musl"
subpackages="$pkgname-doc $pkgname-dev"
source="https://laurikari.net/tre/tre-$pkgver.tar.bz2"

build() {
	cd "$srcdir/$pkgname-$pkgver"
 	./configure --prefix=/usr --enable-static
	make
}

package() {
	make DESTDIR="$pkgdir" install

}

sha512sums="db7465993e0d25eee8e52f974427b8a040234cf0f017769eb94ee88bc6261821336aad7f762bfa82db7e2212d8449bc221592586f061c528a59a550773cbc263  tre-0.8.0.tar.bz2"
-- 
2.28.0
Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20201014100422.GA16738@arya.arvanta.net>
In-Reply-To
<20201014080446.15248-1-alhassanaraouf@disroot.org> (view parent)
DKIM signature
missing
Download raw message
Hi,

I tried to build it as it is posted but it fail.
Maybe consider using version from https://github.com/laurikari/tre/

On Wed, 2020-10-14 at 10:04, Al-Hassan Abdel-Raouf wrote:
> https://laurikari.net/tre
> POSIX compliant regexp matching library.
> Includes agrep for approximate grepping.
> ---
>  testing/tre/APKBUILD | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 testing/tre/APKBUILD
> 
> diff --git a/testing/tre/APKBUILD b/testing/tre/APKBUILD
> new file mode 100644
> index 0000000000..4eb0e68fe4
> --- /dev/null
> +++ b/testing/tre/APKBUILD
> @@ -0,0 +1,25 @@
> +# Contributor:
> +# Maintainer:

It is not good idea to introduce package if no one intend to maintain
it.

> +pkgname=tre
> +pkgver=0.8.0
> +pkgrel=0
> +pkgdesc="POSIX compliant regexp matching library. Includes agrep for approximate grepping."
> +url="https://laurikari.net/tre"
> +arch="all"
> +license="BSD"
> +depends="musl"
            ^^^^
This is not needed, it is by default.

> +subpackages="$pkgname-doc $pkgname-dev"
> +source="https://laurikari.net/tre/tre-$pkgver.tar.bz2"
> +
> +build() {
> +	cd "$srcdir/$pkgname-$pkgver"
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Also this is not needed, it is default
> + 	./configure --prefix=/usr --enable-static
> +	make

Keep these two aligned, i.e. equally indented
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +
> +}
> +
> +sha512sums="db7465993e0d25eee8e52f974427b8a040234cf0f017769eb94ee88bc6261821336aad7f762bfa82db7e2212d8449bc221592586f061c528a59a550773cbc263  tre-0.8.0.tar.bz2"
> -- 
> 2.28.0
Al-Hassan Abdel-Raouf <alhassanaraouf@disroot.org>
Details
Message ID
<20201014131818.GA8062@alhassan-pc.my.domain>
In-Reply-To
<20201014080446.15248-1-alhassanaraouf@disroot.org> (view parent)
DKIM signature
missing
Download raw message
i will fix error shortly,

but for other comments,
i would love to mantain that package whenever i am available, but for next couple of monthes i will not be available that much and the package maybe weeks behind if update comes in

the version on website is well tested and have less dependencies
and it's actually easier to build,
is it says any error msg? or any clue why it fail to build
Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20201014150945.GA6448@arya.arvanta.net>
In-Reply-To
<20201014131818.GA8062@alhassan-pc.my.domain> (view parent)
DKIM signature
missing
Download raw message
Hi,

On Wed, 2020-10-14 at 15:18, Al-Hassan Abdel-Raouf wrote:
> i will fix error shortly,
> 
> but for other comments,
> i would love to mantain that package whenever i am available, but for next couple of monthes i will not be available that much and the package maybe weeks behind if update comes in

That is ok, especially with software which don't have errors.
Someone will upgrade or/and even fix it if you are not available.
So you can add yourself in Maintainer field without problem.
 
> the version on website is well tested and have less dependencies
> and it's actually easier to build,
> is it says any error msg? or any clue why it fail to build

I will put in gitlab.alpinelinux.org/aports where CI will try to build
it and show all errors or success.

BTW, gitlab.alpinelinux.org is preferred workflow for Alpine
development.

-- 
regards
Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20201014152753.GA8760@arya.arvanta.net>
In-Reply-To
<20201014150945.GA6448@arya.arvanta.net> (view parent)
DKIM signature
missing
Download raw message
Hi Al-Hassan,

On Wed, 2020-10-14 at 17:09, Milan P. Stanić wrote:
> On Wed, 2020-10-14 at 15:18, Al-Hassan Abdel-Raouf wrote:
> > i will fix error shortly,
> > 
> > but for other comments,
> > i would love to mantain that package whenever i am available, but for next couple of monthes i will not be available that much and the package maybe weeks behind if update comes in
> 
> That is ok, especially with software which don't have errors.
> Someone will upgrade or/and even fix it if you are not available.
> So you can add yourself in Maintainer field without problem.
>  
> > the version on website is well tested and have less dependencies
> > and it's actually easier to build,
> > is it says any error msg? or any clue why it fail to build
> 
> I will put in gitlab.alpinelinux.org/aports where CI will try to build
> it and show all errors or success.

Here is merge request: 
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/13610

You can see where it fails.

> BTW, gitlab.alpinelinux.org is preferred workflow for Alpine
> development.

-- 
regards
Reply to thread Export thread (mbox)