On Wed Jan 15, 2020 at 7:54 AM, Tiago Ilieve wrote:
> - Doesn't the patch make sense anymore? I've not been following the
> state of Go race condition check in musl lately.

That patch affects the makefile, which is now not used.

> - Does it make sense to drop the version information from the binary?
> I'm inferring that, as the software is being installed by a package
> manager, you are considering this information to be irrelevant.

We can update this to specify the version information in a manner
similar to how the prometheus package does it. Good point for v2.

> - If the binary name is being changed, why opt for
> 'prometheus_node_exporter' (with underscores) instead of
> 'prometheus-node-exporter' (with hyphens), like other distributions[1]
> are doing?

It doesn't really matter (you use it through the init.d file), but we
can change this too.

> - Changing the default binding to 127.0.0.1:9100 might break user
> expectations, as it currently defaults to 0.0.0.0:9100. My use cases,
> for instance, always involved fetching data from it remotely. Binding
> it to localhost by default seems too restrictive in this case, akin to
> doing the same to a HTTP server.

Ack, let's use 0.0.0.0.

Hi Drew,

On Thu, 16 Jan 2020 at 20:08, Drew DeVault <sir@cmpwn.com> wrote:
> That patch affects the makefile, which is now not used.

Great. I hadn't noticed it in the first time.

> We can update this to specify the version information in a manner
> similar to how the prometheus package does it. Good point for v2.

No problem.

> It doesn't really matter (you use it through the init.d file), but we
> can change this too.

> Ack, let's use 0.0.0.0.

Thanks. Please let me know if you need another round of review.

Regards,
Tiago.


--
Tiago "Myhro" Ilieve
Blog: https://blog.myhro.info/
GitHub: https://github.com/myhro
LinkedIn: https://www.linkedin.com/in/myhro/
Montes Claros, Brazil