5 3

[alpine-aports] [PATCH] main/rtorrent: Add libxml2-dev to ensure xmlrpc/scgi support

Hervé Rousseau
Details
Message ID
<1456299506-31-1-git-send-email-herve@moulticast.net>
Sender timestamp
1456299506
DKIM signature
missing
Download raw message
Patch: +1 -1
(with correct commit msg/subject it's always better)

APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.
./configure returns this:
checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
/usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
ok

---
 main/rtorrent/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
index 2ef3c4b..49a9462 100644
--- a/main/rtorrent/APKBUILD
+++ b/main/rtorrent/APKBUILD
@@ -8,7 +8,7 @@ pkgdesc="Ncurses BitTorrent client based on libTorrent"
 url="http://rakshasa.github.io/rtorrent/"
 license="GPL"
 arch="all"
-makedepends="libsigc++-dev libtorrent-dev curl-dev xmlrpc-c-dev ncurses-dev"
+makedepends="libsigc++-dev libtorrent-dev libxml2-dev curl-dev xmlrpc-c-dev ncurses-dev"
 subpackages="$pkgname-doc"
 source="http://rtorrent.net/downloads/${pkgname}-${pkgver}.tar.gz"
 
-- 
2.6.4



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Isaac Dunham
Details
Message ID
<20160225024934.GA9832@newbook>
In-Reply-To
<1456299506-31-1-git-send-email-herve@moulticast.net> (view parent)
Sender timestamp
1456368576
DKIM signature
missing
Download raw message
On Wed, Feb 24, 2016 at 07:38:26AM +0000, Hervé Rousseau wrote:
> (with correct commit msg/subject it's always better)
> 
> APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.
> ./configure returns this:
> checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
> /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found

I see two issues with this patch:
- you need to bump pkgrel to trigger a rebuild

- that error means that the xmlrpc-c-config script is missing a dependency
that it should have.

In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
it's not possible to use it without libxml2-dev.

Of course, if you fix that, you'd still need to bump rtorrent to pick up
the fix (and possibly more packages).


HTH,
Isaac Dunham

> ---
>  main/rtorrent/APKBUILD | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
> index 2ef3c4b..49a9462 100644
> --- a/main/rtorrent/APKBUILD
> +++ b/main/rtorrent/APKBUILD
> @@ -8,7 +8,7 @@ pkgdesc="Ncurses BitTorrent client based on libTorrent"
>  url="http://rakshasa.github.io/rtorrent/"
>  license="GPL"
>  arch="all"
> -makedepends="libsigc++-dev libtorrent-dev curl-dev xmlrpc-c-dev ncurses-dev"
> +makedepends="libsigc++-dev libtorrent-dev libxml2-dev curl-dev xmlrpc-c-dev ncurses-dev"
>  subpackages="$pkgname-doc"
>  source="http://rtorrent.net/downloads/${pkgname}-${pkgver}.tar.gz"
>  
> -- 
> 2.6.4
> 
> 
> 
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
> 


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20160225102125.5af2b450@ncopa-desktop.alpinelinux.org>
In-Reply-To
<20160225024934.GA9832@newbook> (view parent)
Sender timestamp
1456392085
DKIM signature
missing
Download raw message
On Wed, 24 Feb 2016 18:49:36 -0800
Isaac Dunham <ibid.ag@gmail.com> wrote:

> On Wed, Feb 24, 2016 at 07:38:26AM +0000, Hervé Rousseau wrote:
> > (with correct commit msg/subject it's always better)
> > 
> > APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.
> > ./configure returns this:
> > checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
> > /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found  
> 
> I see two issues with this patch:
> - you need to bump pkgrel to trigger a rebuild
> 
> - that error means that the xmlrpc-c-config script is missing a dependency
> that it should have.
> 
> In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
> it's not possible to use it without libxml2-dev.
> 
> Of course, if you fix that, you'd still need to bump rtorrent to pick up
> the fix (and possibly more packages).

I agree with Dunham on all those.

I'd also like commit message reformatted (wrap words at 72 chars,
remove text that is not intended for the git history)

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

[alpine-aports] [PATCH v2 1/2] main/xmlrpc-c: add depends_dev on libxml2-dev

Hervé Rousseau
Details
Message ID
<1456470901-345-1-git-send-email-herve@moulticast.net>
In-Reply-To
<20160225102125.5af2b450@ncopa-desktop.alpinelinux.org> (view parent)
Sender timestamp
1456470900
DKIM signature
missing
Download raw message
Patch: +2 -1
---
Changes v1 -> v2:
 - Add depends_dev on libxml2-dev
 - Bump pkgrel

 main/xmlrpc-c/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/xmlrpc-c/APKBUILD b/main/xmlrpc-c/APKBUILD
index cb264ca..0176c0a 100644
--- a/main/xmlrpc-c/APKBUILD
+++ b/main/xmlrpc-c/APKBUILD
@@ -1,12 +1,13 @@
 # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=xmlrpc-c
 pkgver=1.33.18
-pkgrel=0
+pkgrel=1
 pkgdesc="This library provides a modular implementation of XML-RPC for C and C++"
 url="http://xmlrpc-c.sourceforge.net/"
 arch="all"
 license="BSD and MIT"
 depends=
+depends_dev="libxml2-dev"
 makedepends="libtool curl-dev libxml2-dev zlib-dev"
 subpackages="$pkgname-dev $pkgname-doc $pkgname-client
 	$pkgname-client++:clientxx xmlrpc-c++:cxx $pkgname-abyss"
-- 
2.6.4



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

[alpine-aports] [PATCH v2 2/2] main/rtorrent: bump pkgrel to get xmlrpc-c-dev dependencies

Hervé Rousseau
Details
Message ID
<1456470901-345-2-git-send-email-herve@moulticast.net>
In-Reply-To
<1456470901-345-1-git-send-email-herve@moulticast.net> (view parent)
Sender timestamp
1456470901
DKIM signature
missing
Download raw message
Patch: +1 -1
---
Changes v1 -> v2:
- Bump pkgrel to trigger rebuild with XMLRPC support

 main/rtorrent/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
index 2ef3c4b..37484ce 100644
--- a/main/rtorrent/APKBUILD
+++ b/main/rtorrent/APKBUILD
@@ -3,7 +3,7 @@
 # Maintainer: Bartłomiej Piotrowski <nospam@bpiotrowski.pl>
 pkgname=rtorrent
 pkgver=0.9.6
-pkgrel=1
+pkgrel=2
 pkgdesc="Ncurses BitTorrent client based on libTorrent"
 url="http://rakshasa.github.io/rtorrent/"
 license="GPL"
-- 
2.6.4



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] [PATCH v2 1/2] main/xmlrpc-c: add depends_dev on libxml2-dev

Natanael Copa
Details
Message ID
<20160226145951.32de5097@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1456470901-345-1-git-send-email-herve@moulticast.net> (view parent)
Sender timestamp
1456495191
DKIM signature
missing
Download raw message
On Fri, 26 Feb 2016 07:15:00 +0000
Hervé Rousseau <herve@moulticast.net> wrote:

> ---
> Changes v1 -> v2:
>  - Add depends_dev on libxml2-dev
>  - Bump pkgrel

Thank you for 2 beautiful patches!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---